-
Notifications
You must be signed in to change notification settings - Fork 27
Feature/nayara dark mode UI #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
eb577ac
f6fdee6
ab542b6
2aa4efb
960bf44
6576ace
52d2457
c8e9d84
b081101
c9a6f6e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,10 +1,11 @@ | ||||||||||||||
| import { Button } from "@/components/ui/button"; | ||||||||||||||
| import { Badge } from "@/components/ui/badge"; | ||||||||||||||
| import { Card, CardContent } from "@/components/ui/card"; | ||||||||||||||
| import { Input } from "@/components/ui/input"; | ||||||||||||||
| import type { JobFile } from "@/types/jobs"; | ||||||||||||||
| import { RefreshCcw, Search } from "lucide-react"; | ||||||||||||||
| import type { Dispatch, SetStateAction } from "react"; | ||||||||||||||
| import type { JobFile, JobsMeta } from "@/types/jobs"; | ||||||||||||||
| import { Search } from "lucide-react"; | ||||||||||||||
| import type { Dispatch, ReactNode, SetStateAction } from "react"; | ||||||||||||||
|
|
||||||||||||||
| import { BriefcaseBusiness, FileSpreadsheet } from "lucide-react"; | ||||||||||||||
|
Comment on lines
+5
to
+8
|
||||||||||||||
| import { Search } from "lucide-react"; | |
| import type { Dispatch, ReactNode, SetStateAction } from "react"; | |
| import { BriefcaseBusiness, FileSpreadsheet } from "lucide-react"; | |
| import { Search, BriefcaseBusiness, FileSpreadsheet } from "lucide-react"; | |
| import type { Dispatch, ReactNode, SetStateAction } from "react"; |
Copilot
AI
Mar 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JobsFiltersCard props were changed (removed loading/onRefresh, added required meta and optional actions). The existing unit tests for this component still pass the old props, so they will fail to compile/run. Update the tests to pass meta and assert the new UI/behavior.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,34 +1,27 @@ | ||||||
| import { Badge } from "@/components/ui/badge"; | ||||||
| import { Card, CardDescription, CardHeader, CardTitle } from "@/components/ui/card"; | ||||||
| import type { JobsMeta } from "@/types/jobs"; | ||||||
| import { BriefcaseBusiness, FileSpreadsheet } from "lucide-react"; | ||||||
| import type { ReactNode } from "react"; | ||||||
| import { | ||||||
| CardDescription, | ||||||
| CardTitle, | ||||||
| } from "@/components/ui/card"; | ||||||
| import Logo from "../assets/logo-painel-vagas.svg"; | ||||||
| import { ThemeToggle } from "@/components/ui/theme-toggle"; | ||||||
| import { useTheme } from "@/hooks/useTheme"; | ||||||
|
|
||||||
| interface JobsHeaderCardProps { | ||||||
| meta: JobsMeta; | ||||||
| actions?: ReactNode; | ||||||
| } | ||||||
|
|
||||||
| export function JobsHeaderCard({ meta, actions }: JobsHeaderCardProps) { | ||||||
| export function JobsHeaderCard() { | ||||||
|
||||||
| export function JobsHeaderCard() { | |
| export function JobsHeaderCard(_props: JobsHeaderCardProps) { |
Copilot
AI
Mar 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header background uses hard-coded hex colors (bg-[#004726] / dark:bg-[#003318]), bypassing the design tokens defined via CSS variables/Tailwind theme. Consider using token-based classes (e.g., bg-primary / bg-background / bg-card) or introducing a dedicated CSS variable so the dark-mode palette stays centralized and adjustable.
| <div className="w-screen bg-[#004726] dark:bg-[#003318] p-6 -mx-8 flex items-end"> | |
| <div className="w-screen bg-primary p-6 -mx-8 flex items-end"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -35,7 +35,7 @@ export function JobsTableCard({ | |||||
| onPageSizeChange, | ||||||
| }: JobsTableCardProps) { | ||||||
| return ( | ||||||
| <Card className="border-border/70 bg-card/90 backdrop-blur dark:bg-card/95"> | ||||||
| <Card className="border-border/70 bg-card/90 backdrop-blur dark:bg-card/95 mb-4"> | ||||||
| <CardHeader> | ||||||
| <CardTitle className="text-lg">Vagas Encontradas</CardTitle> | ||||||
| <CardDescription> | ||||||
|
|
@@ -44,7 +44,7 @@ export function JobsTableCard({ | |||||
| </CardHeader> | ||||||
| <CardContent> | ||||||
| {error ? ( | ||||||
| <div className="rounded-md border border-red-500/40 bg-red-500/10 p-4 text-sm text-red-700 dark:text-red-300"> | ||||||
| <div className="rounded-md border border-red-500/40 bg-red-500/10 p-4 text-sm text-red-700 dark:text-red-300 mb-4"> | ||||||
| {error} | ||||||
| </div> | ||||||
| ) : null} | ||||||
|
|
@@ -91,36 +91,36 @@ export function JobsTableCard({ | |||||
| <Table> | ||||||
| <TableHeader> | ||||||
| <TableRow> | ||||||
| <TableHead>Palavra-chave</TableHead> | ||||||
| <TableHead>Titulo</TableHead> | ||||||
| <TableHead>Empresa</TableHead> | ||||||
| <TableHead>Fonte</TableHead> | ||||||
| <TableHead>Local</TableHead> | ||||||
| <TableHead>Link</TableHead> | ||||||
| <TableHead>Palavra-chave</TableHead> | ||||||
| <TableHead>Fonte</TableHead> | ||||||
| </TableRow> | ||||||
|
Comment on lines
94
to
100
|
||||||
| </TableHeader> | ||||||
| <TableBody> | ||||||
| {paginatedJobs.map((job, index) => ( | ||||||
| <TableRow key={`${job.link || `${job.titulo || "vaga"}-${index}`}-${index}`}> | ||||||
| <TableCell>{job.palavra || "-"}</TableCell> | ||||||
| <TableCell className="font-medium">{job.titulo || "-"}</TableCell> | ||||||
| <TableCell>{job.empresa || "-"}</TableCell> | ||||||
| <TableCell>{job.source || "-"}</TableCell> | ||||||
| <TableCell>{job.local || "-"}</TableCell> | ||||||
| <TableCell> | ||||||
| {job.link ? ( | ||||||
| <a | ||||||
| href={job.link} | ||||||
| target="_blank" | ||||||
| rel="noreferrer" | ||||||
| className="text-primary underline-offset-4 hover:underline" | ||||||
| className="text-primary underline-offset-4 hover:underline dark:text-[#14AE5C]" | ||||||
|
||||||
| className="text-primary underline-offset-4 hover:underline dark:text-[#14AE5C]" | |
| className="text-primary underline-offset-4 hover:underline" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appnow rendersJobsHeaderCardwithout the previous title text/props and moved the primary action intoJobsFiltersCard. The existingfrontend/tests/unit/pages/App.test.tsxassertions/mocks (e.g., expecting "Painel de Vagas" and mockinguseJobsDatawithoutscraping/triggerScraper) will need updating to match this new composition, otherwise CI will fail.