Skip to content

Commit 3844adf

Browse files
committed
Address CodeRabbit review
- config/detekt.yml: fix over-escaped ForbiddenComment allowedPatterns regex (YAML single-quotes don't process escapes; 'TODO\\(.*\\):' was matching literal backslashes instead of parentheses) - AndroidCliPluginTest: construct fresh SettingsExtension in each when{} scope so defaults and mutation leaves don't share state
1 parent 42beb8e commit 3844adf

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

config/detekt.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ style:
103103
- 'TODO:'
104104
- 'FIXME:'
105105
- 'HACK:'
106-
allowedPatterns: 'TODO\\(.*\\):'
106+
allowedPatterns: 'TODO\(.*\):'
107107
MagicNumber:
108108
active: true
109109
ignoreNumbers:

plugin/src/test/kotlin/zone/clanker/gradle/androidcli/AndroidCliPluginTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,8 @@ class AndroidCliPluginTest :
4545
}
4646

4747
given("AndroidCli.SettingsExtension") {
48-
val ext = AndroidCli.SettingsExtension()
49-
5048
`when`("created with defaults") {
49+
val ext = AndroidCli.SettingsExtension()
5150
then("binary defaults to android") {
5251
ext.binary shouldBe "android"
5352
}
@@ -57,6 +56,7 @@ class AndroidCliPluginTest :
5756
}
5857

5958
`when`("properties are set") {
59+
val ext = AndroidCli.SettingsExtension()
6060
then("binary is mutable") {
6161
ext.binary = "/opt/android/bin/android"
6262
ext.binary shouldBe "/opt/android/bin/android"

0 commit comments

Comments
 (0)