Upd. Scan. Improve Surface flow to count files.#652
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Surface scanner’s directory traversal to be deterministic so that scan resumption (based on on_exit_dir_offset) can reliably continue from the correct position across requests.
Changes:
- Materialize and sort a directory’s entries before iterating to ensure stable ordering across runs.
- Switch resume-path comparisons and saved
on_exit_dir_pathfrom$it->getPath()to the explicit$main_path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glomberg
approved these changes
May 4, 2026
alexander-b-clean
approved these changes
May 4, 2026
svfcode
added a commit
that referenced
this pull request
May 12, 2026
* Queue log removed. * Upd. Logging FW update. * Upd. Logging FW update. Auto-tests. * Fix. Logger. Logs update fixed. * Upd. Logger. Dev merge and fixes. * Code. Code Review * Code. Code Review * upd version * upd version * Code. Code Review * Code. Code Review * Code. Code Review * Code. Code Review * Mod. React. Continue switch auth block. (#640) * Mod. React. Continue switch auth block. * Mod. React. Switch auth block. * fix eslint * fix psalm * upd * fix hints * upd hint again * Fix. Settings. Fix 2fa option switch. * ref by review * ref by review * fix typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Upd. Settings. Improve modal layout. * reminify * fix eslint --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix. Code. Github action fixed (xdebug activated). * Mod. Link. Changing the link * Upd. Scan. Improve Surface flow to count files. (#652) * Upd. Scan. Improve Surface flow to count files. * Upd. Scan. Improve Surface flow to count files. * Upd. Scan. Improve Surface flow to count files. * Upd. Scan. Improve Surface flow to count files. * Update changelog * Upd. Banners. Improved statement of show banner. --------- Co-authored-by: alexandergull <alex.g@cleantalk.org> Co-authored-by: datorik <datorik@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Glomberg <bazz@bk.ru> Co-authored-by: AntonV1211 <antonV1211@yandex.ru> Co-authored-by: Aleksandr Banins <alexander.b@cleantalk.org> Co-authored-by: AntonV1211 <39616556+AntonV1211@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task https://app.doboard.com/1/task/48075