Upd. Settings. Improved counting of FW nets.#671
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Security Firewall statistics calculation by changing how the plugin counts “covered IPs” at the end of a firewall update, replacing the previous SQL-based IPv6 estimation with a PHP-side IPv6 prefix-length calculation.
Changes:
- Added an IPv6-specific counting routine (
spbc_security_firewall_update__get_ipv6_ips_count()). - Updated
spbc_security_firewall_update__get_ips_count()to compute IPv4 counts via SQL and IPv6 counts via the new helper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AntonV1211
approved these changes
Jun 15, 2026
alexandergull
approved these changes
Jun 15, 2026
Glomberg
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task https://app.doboard.com/1/task/42707