Fix. Code. Psalm errors fixed (#787)

* Fix. Psalm error fix

* Fix. Psalm error fix

---------

Co-authored-by: datorik <datorik@gmail.com>

Author: alexander-b-clean

cleantalk.php

@@ -2136,7 +2136,7 @@ function apbct_rc__install_plugin($_wp = null, $plugin = null)
                     die(
                         'FAIL ' . json_encode(array(
                             'error'   => 'FAIL_TO_GET_LATEST_VERSION',
-                            'details' => $result instanceof WP_Error ? $result->get_error_message() : '',
+                            'details' => $result->get_error_message(),
                         ))
                     );
                 }
@@ -2170,12 +2170,9 @@ function apbct_rc__activate_plugin($plugin)
             $result = activate_plugins($plugin);
 
             $result_array = array('success' => true);
-            $error_msg = '';
 
             if (!$result || is_wp_error($result)) {
-                if ($result instanceof WP_Error) {
-                    $error_msg = ' ' . $result->get_error_message();
-                }
+                $error_msg = ' ' . $result->get_error_message();
                 $result_array = array(
                     'error'   => 'FAIL_TO_ACTIVATE',
                     'details' => $error_msg
@@ -2293,7 +2290,7 @@ function apbct_rc__uninstall_plugin($plugin = null)
             $error_msg = '';
 
             if (!$result || is_wp_error($result)) {
-                if ($result instanceof WP_Error) {
+                if (is_wp_error($result) && $result->get_error_message()) {
                     $error_msg = ' ' . $result->get_error_message();
                 }
                 $die_string = 'FAIL ' . json_encode(array(

lib/Cleantalk/ApbctWP/FindSpam/ListTable/BadUsers.php

@@ -21,7 +21,7 @@ public function prepare_items()  // phpcs:ignore PSR1.Methods.CamelCapsMethodNam
 
         $current_screen = get_current_screen();
         $per_page_option = !is_null($current_screen)
-            ? $current_screen->get_option('per_page', 'option')
+            ? ($current_screen->get_option('per_page', 'option') ?? '10')
             : '10';
         $per_page        = get_user_meta(get_current_user_id(), $per_page_option, true);
         if ( ! $per_page ) {

lib/Cleantalk/ApbctWP/FindSpam/ListTable/CommentsScan.php

@@ -11,7 +11,7 @@ public function prepare_items() // phpcs:ignore PSR1.Methods.CamelCapsMethodName
 
         $current_screen = get_current_screen();
         $per_page_option = !is_null($current_screen)
-            ? $current_screen->get_option('per_page', 'option')
+            ? ($current_screen->get_option('per_page', 'option') ?? '10')
             : '10';
         $per_page        = get_user_meta(get_current_user_id(), $per_page_option, true);
         if ( ! $per_page ) {

lib/Cleantalk/ApbctWP/FindSpam/ListTable/UsersScan.php

@@ -10,7 +10,7 @@ public function prepare_items() // phpcs:ignore PSR1.Methods.CamelCapsMethodName
     {
         $current_screen = get_current_screen();
         $per_page_option = !is_null($current_screen)
-            ? $current_screen->get_option('per_page', 'option')
+            ? ($current_screen->get_option('per_page', 'option') ?? '10')
             : '10';
         $per_page        = get_user_meta(get_current_user_id(), $per_page_option, true);
         if ( ! $per_page ) {