Skip to content

Commit 8cb8753

Browse files
committed
remove panel layer
1 parent f175405 commit 8cb8753

7 files changed

Lines changed: 14 additions & 20 deletions

File tree

src/main/java/com/cleanroommc/modularui/api/widget/IWidget.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ default void draw(ModularGuiContext context) {
9292
void drawForeground(ModularGuiContext context);
9393

9494
default void transform(IViewportStack stack) {
95-
stack.translate(getArea().rx, getArea().ry, getArea().getPanelLayer() * 20);
95+
stack.translate(getArea().rx, getArea().ry, 0);
9696
}
9797

9898
default Object getAdditionalHoverInfo(IViewportStack viewportStack, int mouseX, int mouseY) {

src/main/java/com/cleanroommc/modularui/screen/ModularScreen.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ public void drawScreen() {
291291
this.context.reset();
292292
this.context.pushViewport(null, this.context.getScreenArea());
293293
for (ModularPanel panel : this.panelManager.getReverseOpenPanels()) {
294-
this.context.updateZ(panel.getArea().getPanelLayer() * 20);
294+
this.context.updateZ(0);
295295
if (panel.disablePanelsBelow()) {
296296
GuiDraw.drawRect(0, 0, this.context.getScreenArea().w(), this.context.getScreenArea().h(), Color.argb(16, 16, 16, (int) (125 * panel.getAlpha())));
297297
}
@@ -324,7 +324,7 @@ public void drawForeground() {
324324
this.context.reset();
325325
this.context.pushViewport(null, this.context.getScreenArea());
326326
for (ModularPanel panel : this.panelManager.getReverseOpenPanels()) {
327-
this.context.updateZ(100 + panel.getArea().getPanelLayer() * 20);
327+
this.context.updateZ(100);
328328
if (panel.isEnabled()) {
329329
WidgetTree.drawTreeForeground(panel, this.context);
330330
}

src/main/java/com/cleanroommc/modularui/screen/PanelManager.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ private void openPanel(ModularPanel panel, boolean resize) {
9797
panel.setPanelGuiContext(this.screen.getContext());
9898
this.panels.addFirst(panel);
9999
this.dirty = true;
100-
panel.getArea().setPanelLayer((byte) this.panels.size());
101100
panel.onOpen(this.screen);
102101
if (resize) {
103102
WidgetTree.resizeInternal(panel, true);

src/main/java/com/cleanroommc/modularui/widget/EmptyWidget.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ public ModularScreen getScreen() {
2929
@Override
3030
public void initialise(@NotNull IWidget parent, boolean late) {
3131
this.parent = parent;
32-
getArea().setPanelLayer(getParent().getArea().getPanelLayer());
3332
getArea().z(parent.getArea().z() + 1);
3433
}
3534

src/main/java/com/cleanroommc/modularui/widget/Widget.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ public final void initialise(@NotNull IWidget parent, boolean late) {
101101
this.parent = parent;
102102
this.panel = parent.getPanel();
103103
this.context = parent.getContext();
104-
getArea().setPanelLayer(this.panel.getArea().getPanelLayer());
105104
getArea().z(parent.getArea().z() + 1);
106105
if (this.guiActionListeners != null) {
107106
for (IGuiAction action : this.guiActionListeners) {

src/main/java/com/cleanroommc/modularui/widget/sizer/Area.java

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
import com.cleanroommc.modularui.utils.Interpolations;
88
import com.cleanroommc.modularui.utils.MathUtils;
99

10+
import org.jetbrains.annotations.ApiStatus;
11+
1012
import java.awt.*;
1113
import java.awt.geom.Rectangle2D;
1214
import java.util.Objects;
@@ -30,10 +32,6 @@ public static boolean isInside(int x, int y, int w, int h, int px, int py) {
3032
* relative position (in most cases the direct parent)
3133
*/
3234
public int rx, ry;
33-
/**
34-
* each panel has its own layer
35-
*/
36-
private byte panelLayer = 0;
3735
/**
3836
* the widget layer within this panel
3937
*/
@@ -55,7 +53,6 @@ public Area(Area area) {
5553
super(area);
5654
this.rx = area.rx;
5755
this.ry = area.ry;
58-
this.panelLayer = area.panelLayer;
5956
this.z = area.z;
6057
getMargin().set(area.getMargin());
6158
getPadding().set(area.getPadding());
@@ -125,13 +122,15 @@ public void z(int z) {
125122
this.z = z;
126123
}
127124

125+
@ApiStatus.ScheduledForRemoval(inVersion = "3.2.0")
126+
@Deprecated
128127
public byte getPanelLayer() {
129-
return this.panelLayer;
128+
return 0;
130129
}
131130

132-
public void setPanelLayer(byte panelLayer) {
133-
this.panelLayer = panelLayer;
134-
}
131+
@ApiStatus.ScheduledForRemoval(inVersion = "3.2.0")
132+
@Deprecated
133+
public void setPanelLayer(byte panelLayer) {}
135134

136135
/**
137136
* Calculate X based on anchor value
@@ -557,13 +556,13 @@ public boolean equals(Object o) {
557556
if (o == null || getClass() != o.getClass()) return false;
558557
if (!super.equals(o)) return false;
559558
Area area = (Area) o;
560-
return rx == area.rx && ry == area.ry && panelLayer == area.panelLayer && z == area.z && Objects.equals(getMargin(),
559+
return rx == area.rx && ry == area.ry && z == area.z && Objects.equals(getMargin(),
561560
area.getMargin()) && Objects.equals(
562561
getPadding(), area.getPadding());
563562
}
564563

565564
@Override
566565
public int hashCode() {
567-
return Objects.hash(super.hashCode(), rx, ry, panelLayer, z, getMargin(), getPadding());
566+
return Objects.hash(super.hashCode(), rx, ry, z, getMargin(), getPadding());
568567
}
569568
}

src/main/java/com/cleanroommc/modularui/widget/sizer/Flex.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -433,10 +433,8 @@ public boolean isYMarginPaddingApplied() {
433433
public boolean resize(IGuiElement guiElement, boolean isParentLayout) {
434434
IResizeable relativeTo = getRelativeTo();
435435
Area relativeArea = relativeTo.getArea();
436-
byte panelLayer = this.parent.getArea().getPanelLayer();
437436

438-
if (!this.bypassLayerRestriction && (relativeArea.getPanelLayer() > panelLayer ||
439-
(relativeArea.getPanelLayer() == panelLayer && relativeArea.z() >= this.parent.getArea().z()))) {
437+
if (!this.bypassLayerRestriction && relativeArea.z() >= this.parent.getArea().z()) {
440438
Area area = guiElement.getArea();
441439
area.setSize(18, 18);
442440
area.rx = 0;

0 commit comments

Comments
 (0)