Fix Crash when Clicking on a non-slot with a stack in hand (#53)

ghzdude · web-flow · commit b6042c868fe1 · 2024-02-16T18:31:08.000+01:00
* fix a crash when clicking in the gui with an item on anything that's not a slot,

* handle -1 slotid when quick moving
diff --git a/src/main/java/com/cleanroommc/modularui/screen/ModularContainer.java b/src/main/java/com/cleanroommc/modularui/screen/ModularContainer.java
@@ -189,6 +189,9 @@ public boolean canInteractWith(@NotNull EntityPlayer playerIn) {
                 }
                 return inventoryplayer.getItemStack();
             }
+
+            if (slotId < 0) return ItemStack.EMPTY;
+
             if (clickTypeIn == ClickType.QUICK_MOVE) {
                 Slot fromSlot = getSlot(slotId);
 

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,9 @@ public boolean canInteractWith(@NotNull EntityPlayer playerIn) {`
`189`	`189`	`}`
`190`	`190`	`return inventoryplayer.getItemStack();`
`191`	`191`	`}`
	`192`	`+`
	`193`	`+ if (slotId < 0) return ItemStack.EMPTY;`
	`194`	`+`
`192`	`195`	`if (clickTypeIn == ClickType.QUICK_MOVE) {`
`193`	`196`	`Slot fromSlot = getSlot(slotId);`
`194`	`197`