Skip to content

Commit 4e5cd1e

Browse files
feat(cc-block, cc-block-details, cc-visual-tests-report-menu): rotate toggle icon
Use an up-arrow icon as the base across the three components and update the logic: - closed: arrow down (rotate 180deg) - open: arrow up (default) - hover: arrow right (rotate 90deg)
1 parent e6b87c2 commit 4e5cd1e

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

src/components/cc-block-details/cc-block-details.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { css, html, LitElement } from 'lit';
2-
import { iconRemixArrowDownSLine as iconArrowDown } from '../../assets/cc-remix.icons.js';
2+
import { iconRemixArrowUpSLine as iconArrowUp } from '../../assets/cc-remix.icons.js';
33
import '../cc-icon/cc-icon.js';
44
import { CcToggleEvent } from '../common.events.js';
55

@@ -39,7 +39,7 @@ export class CcBlockDetails extends LitElement {
3939
<div class="btn-wrapper">
4040
<button class="button" aria-expanded="${this.isOpen}" aria-controls="content" @click=${this._onClickToggle}>
4141
<slot name="button-text"></slot>
42-
<cc-icon .icon="${iconArrowDown}"></cc-icon>
42+
<cc-icon .icon="${iconArrowUp}"></cc-icon>
4343
</button>
4444
</div>
4545
<div id="content" class="content">
@@ -116,11 +116,11 @@ export class CcBlockDetails extends LitElement {
116116
transition: all 0.3s;
117117
}
118118
119-
:host([is-open]) .button cc-icon {
119+
.button[aria-expanded='false'] cc-icon {
120120
transform: rotate(180deg);
121121
}
122122
123-
:host(:not([is-open])) .button:hover cc-icon {
123+
.button:hover cc-icon {
124124
transform: rotate(90deg);
125125
}
126126

src/components/cc-block/cc-block.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { css, html, LitElement } from 'lit';
22
import { classMap } from 'lit/directives/class-map.js';
3-
import { iconRemixArrowDownSLine as iconArrowDown } from '../../assets/cc-remix.icons.js';
3+
import { iconRemixArrowUpSLine as iconArrowUp } from '../../assets/cc-remix.icons.js';
44
import { hasSlottedChildren } from '../../directives/has-slotted-children.js';
55
import { isStringEmpty } from '../../lib/utils.js';
66
import '../cc-button/cc-button.js';
@@ -93,7 +93,7 @@ export class CcBlock extends LitElement {
9393
@click=${this._onClickToggle}
9494
>
9595
${this._renderHeader()}
96-
<cc-icon class="toggle-icon" .icon=${iconArrowDown} size="xl"></cc-icon>
96+
<cc-icon class="toggle-icon" .icon=${iconArrowUp} size="xl"></cc-icon>
9797
</button>
9898
`
9999
: this._renderHeader()}
@@ -280,7 +280,7 @@ export class CcBlock extends LitElement {
280280
transition: transform 0.3s ease-out;
281281
}
282282
283-
.toggle-button[aria-expanded='true'] .toggle-icon {
283+
.toggle-button[aria-expanded='false'] .toggle-icon {
284284
transform: rotate(0.5turn);
285285
}
286286

src/components/cc-visual-tests-report-menu/cc-visual-tests-report-menu.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import { LitElement, css, html } from 'lit';
22
import { classMap } from 'lit/directives/class-map.js';
33
import { createRef, ref } from 'lit/directives/ref.js';
44
import {
5-
iconRemixArrowDownSLine as iconArrowDown,
65
iconRemixArrowLeftSLine as iconArrowLeft,
76
iconRemixArrowRightSLine as iconArrowRight,
7+
iconRemixArrowUpSLine as iconArrowUp,
88
} from '../../assets/cc-remix.icons.js';
99
import { camelCaseToSpacedCapitalized, kebabCase } from '../../lib/change-case.js';
1010
import { isVisibleInContainer } from '../../lib/utils.js';
@@ -222,7 +222,7 @@ export class CcVisualTestsReportMenu extends LitElement {
222222
aria-expanded="${isMenuItemOpen}"
223223
aria-controls="stories-${componentTagName}"
224224
>
225-
<cc-icon .icon="${iconArrowDown}"></cc-icon>
225+
<cc-icon .icon="${iconArrowUp}"></cc-icon>
226226
<span>${componentTagName}</span>
227227
</button>
228228
<ul id="stories-${componentTagName}" class="story-list" ?hidden="${!isMenuItemOpen}">
@@ -256,7 +256,7 @@ export class CcVisualTestsReportMenu extends LitElement {
256256
aria-expanded="${isMenuItemOpen}"
257257
aria-controls="${componentTagName}-${kebabCasedStoryName}"
258258
>
259-
<cc-icon .icon="${iconArrowDown}"></cc-icon>
259+
<cc-icon .icon="${iconArrowUp}"></cc-icon>
260260
<span>${storyNameToDisplay}</span>
261261
</button>
262262
<ul id="${componentTagName}-${kebabCasedStoryName}" class="viewport-browser-list" ?hidden="${!isMenuItemOpen}">
@@ -339,7 +339,7 @@ export class CcVisualTestsReportMenu extends LitElement {
339339
transition: transform 0.3s;
340340
}
341341
342-
.btn[aria-expanded='true'] cc-icon {
342+
.btn[aria-expanded='false'] cc-icon {
343343
transform: rotate(180deg);
344344
}
345345

0 commit comments

Comments
 (0)