cc-addon-dashboard components: use the new client instead of hardcoded endpoints#1724
Merged
Merged
Conversation
florian-sanders-cc
force-pushed
the
cc-addon-dashboards/use-new-client
branch
5 times, most recently
from
3753a9a to
23ae39f
Compare
Contributor
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-addon-dashboards/use-new-client/index.html. This preview will be deleted once this PR is closed. |
florian-sanders-cc
force-pushed
the
cc-addon-dashboards/use-new-client
branch
from
23ae39f to
0d63085
Compare
florian-sanders-cc
force-pushed
the
cc-addon-dashboards/use-new-client
branch
2 times, most recently
from
822b4e7 to
c1d52b5
Compare
florian-sanders-cc
force-pushed
the
cc-addon-dashboards/use-new-client
branch
from
c1d52b5 to
c160713
Compare
florian-sanders-cc
force-pushed
the
cc-addon-dashboards/use-new-client
branch
3 times, most recently
from
d42a1b5 to
9ba4ead
Compare
florian-sanders-cc
requested review from
Galimede,
clara-layus-cc,
pdesoyres-cc and
roberttran-cc
pdesoyres-cc
reviewed
Jun 1, 2026
Contributor
pdesoyres-cc
left a comment
pdesoyres-cc
left a comment
There was a problem hiding this comment.
Well done Florian. I have just questions about the use of a 1 second ttl cache. I'm wondering if it is really necessary, knowing that we have a dedup mechanism now.
florian-sanders-cc
force-pushed
the
cc-addon-dashboards/use-new-client
branch
2 times, most recently
from
950df3f to
fbe6aeb
Compare
Remove hardcoded endpoints and use the new client instead
Remove hardcoded endpoints and use the new client instead
Remove hardcoded endpoints and use the new client instead
Since most dashboard components now use types coming from the new client, we no local need to maintain types for API payloads
Since the `@clevercloud/client` package returns `null` instead of throwing when facing a `404` response, we need to make sure the code stops after setting the component state to `error` if data is null
florian-sanders-cc
force-pushed
the
cc-addon-dashboards/use-new-client
branch
from
fbe6aeb to
ed5e0f6
Compare
Contributor
|
🔎 The preview has been automatically deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@clevercloud/clientto12.1.0to benefit from the newly addedOperatorcommands,cc-addon-*.smartcomponent to rely on the new client as much as possible,kubernetes&cellar,cc-addon-header.client.jsfile in the only place where it's now used:cc-addon-header.smart-cellar.js.How to review?
demo-smart(random testing a few of them should be enough, I've run LLM withplaywright-clito test success & error cases + I've tested all success cases manually),TODO