Skip to content

feat(cc-search-bar): init component #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clara-layus-cc merged 2 commits into from
Jun 2, 2026
Merged

feat(cc-search-bar): init component #1733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c955959
refactor(utils): extract isExternalUrl helper from cc-link
clara-layus-cc May 6, 2026
025bfda
feat(cc-search-bar): init component
clara-layus-cc May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions src/components/cc-link/cc-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { css, html, LitElement } from 'lit';
import { classMap } from 'lit/directives/class-map.js';
import { ifDefined } from 'lit/directives/if-defined.js';
import { iconRemixExternalLinkLine as externalLinkIcon, iconRemixDownloadLine } from '../../assets/cc-remix.icons.js';
import { isStringEmpty } from '../../lib/utils.js';
import { isExternalUrl, isStringEmpty } from '../../lib/utils.js';
import { skeletonStyles } from '../../styles/skeleton.js';
import { i18n } from '../../translations/translation.js';
import '../cc-icon/cc-icon.js';
Expand Down Expand Up @@ -83,24 +83,6 @@ export class CcLink extends LitElement {
this._title = '';
}

/**
* Checks if a given URL points to a different origin than the current page.
* If the URL is invalid, it is considered as a different origin for security.
*
* @param {string} rawUrl - The URL to check.
* @returns {boolean} True if the URL points to a different origin, false otherwise.
* @private
*/
_isDifferentOrigin(rawUrl) {
try {
const url = new URL(rawUrl, location.href);
return url.origin !== location.origin;
} catch {
// Consider bad URLs as different origin
return true;
}
}

/**
* Determines the appropriate title for the link
*
Expand Down Expand Up @@ -140,7 +122,7 @@ export class CcLink extends LitElement {

render() {
const href = this.href != null && !this.skeleton ? this.href : null;
const isDifferentOrigin = this._isDifferentOrigin(href);
const isDifferentOrigin = isExternalUrl(href);
const target = isDifferentOrigin ? '_blank' : null;
const rel = isDifferentOrigin ? 'noreferrer' : null;
const disableExternalIcon = this.disableExternalLinkIcon || this.mode !== 'default';
Expand Down
Loading