refactor(application): centralize Sync* calls in Create[T]/Update[T]#403
Draft
TheCrabe wants to merge 1 commit into
Draft
refactor(application): centralize Sync* calls in Create[T]/Update[T]#403TheCrabe wants to merge 1 commit into
TheCrabe wants to merge 1 commit into
Conversation
- move SyncNetworkGroups/SyncExposedVariables/SyncDependencies into the generic Create[T]/Update[T], dropping ~6 duplicated lines per runtime - remove the now-redundant second state save in each Update (its secondary block held only the Sync* calls) - no RuntimePlan interface change: the 3 fields already live on Runtime Closes #370
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #370.
SyncNetworkGroups,SyncExposedVariablesandSyncDependencieswerecalled identically in all 16 runtime
crud.gofiles. They are now invokedonce from the generic
Create[T]/Update[T]functions, like VHosts andEnvironment already are.
Sync*calls intoCreate[T]/Update[T], removing~6 duplicated lines from each runtime
crud.goUpdate— itssecondary block held only the
Sync*calls, and the calls do not mutateplanRuntimePlaninterface change: contrary to the issue's estimate,Networkgroups/ExposedEnvironment/Dependenciesalready live on theshared
Runtimestruct, reachable via the existingGetRuntimePtr()