Skip to content

Fix WASM experimental release build failure#71869

Merged
ZhilkinSerg merged 1 commit into
CleverRaven:masterfrom
BrettDong:fix-wasm-rel
Feb 20, 2024
Merged

Fix WASM experimental release build failure#71869
ZhilkinSerg merged 1 commit into
CleverRaven:masterfrom
BrettDong:fix-wasm-rel

Conversation

@BrettDong

Copy link
Copy Markdown
Member

Summary

None

Purpose of change

WASM experimental release builds are failing (see https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/7970785446/job/21762295535) because #71439 updated the WASM build script to use ccache though ccache is not installed nor planned to be used in an experimental release build.

Describe the solution

Add an environment variable $CCACHE set to 1 only in emscripten.yml but not in release.yml, and use ccache conditionally in build-emscripten.sh.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions Bot added Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 20, 2024
@ZhilkinSerg
ZhilkinSerg merged commit 8839134 into CleverRaven:master Feb 20, 2024
@github-actions github-actions Bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 20, 2024
@BrettDong
BrettDong deleted the fix-wasm-rel branch February 25, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants