Not fitted event counter fix#24
Open
tricasthu wants to merge 2 commits into
Open
Conversation
…erties added date property to DayItemWidget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in not fitted event counter.
For example, have maxEventLines events from the 5th to the 7th (3 days long each). Add an event from the 7th to the 8th (2 days long). It won't be shown because of how the algorithm works (prioritizes longer events), which is fine. +1 will appear on the 7th, which is also fine. However, +1 won't appear on the 8th, however, it should.
I have modified the implementation a little bit to fix this error. When events are selected to be drawn, they are removed from the original event list. At the end of the event placing algorithm, we can know for sure that leftover events are not shown, and there should be a +1 on each day they take place.