Skip to content

Commit 6341ca2

Browse files
authored
change env variable in GHA and add test message to help keep it consistent (#417)
1 parent 40079d4 commit 6341ca2

2 files changed

Lines changed: 14 additions & 10 deletions

File tree

.github/workflows/Tests.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ jobs:
3535
env:
3636
PYTHON: ""
3737
run: |
38-
julia --project -e 'using Conda; Conda.add("python=3.13")'
39-
julia --project -e 'using Conda; Conda.add("scipy=1.17.1")'
40-
julia --project -e 'using Conda; Conda.add("scikit-learn=1.8.0")'
38+
julia --project -e 'using Conda; Conda.add("python=3.11")'
39+
julia --project -e 'using Conda; Conda.add("scipy=1.14.1")'
40+
julia --project -e 'using Conda; Conda.add("scikit-learn=1.5.1")'
4141
julia --project -e 'using Pkg; Pkg.add("PyCall"); Pkg.build("PyCall")'
4242
4343
- name: Run Unit Tests
@@ -91,9 +91,9 @@ jobs:
9191
env:
9292
PYTHON: ""
9393
run: |
94-
julia --project -e 'using Conda; Conda.add("python=3.13")'
95-
julia --project -e 'using Conda; Conda.add("scipy=1.17.1")'
96-
julia --project -e 'using Conda; Conda.add("scikit-learn=1.8.0")'
94+
julia --project -e 'using Conda; Conda.add("python=3.11")'
95+
julia --project -e 'using Conda; Conda.add("scipy=1.14.1")'
96+
julia --project -e 'using Conda; Conda.add("scikit-learn=1.5.1")'
9797
julia --project -e 'using Pkg; Pkg.add("PyCall"); Pkg.build("PyCall")'
9898
9999
- name: Run Unit Tests
@@ -134,9 +134,9 @@ jobs:
134134
env:
135135
PYTHON: ""
136136
run: |
137-
julia --project -e 'using Conda; Conda.add("python=3.13")'
138-
julia --project -e 'using Conda; Conda.add("scipy=1.17.0")'
139-
julia --project -e 'using Conda; Conda.add("scikit-learn=1.8.0")'
137+
julia --project -e 'using Conda; Conda.add("python=3.11")'
138+
julia --project -e 'using Conda; Conda.add("scipy=1.14.1")'
139+
julia --project -e 'using Conda; Conda.add("scikit-learn=1.5.1")'
140140
julia --project -e 'using Pkg; Pkg.add("PyCall"); Pkg.build("PyCall")'
141141
- name: Run Unit Tests
142142
env:

test/runtests.jl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
11
using Test
22

3-
TEST_PLOT_OUTPUT = !isempty(get(ENV, "CES_TEST_PLOT_OUTPUT", ""))
3+
TEST_PLOT_OUTPUT = get(ENV, "CES_TEST_PLOT_OUTPUT", false)
4+
@info "[in test/runtest.jl], create plots? CES_TEST_PLOT_OUTPUT: $(TEST_PLOT_OUTPUT)"
45

56
if TEST_PLOT_OUTPUT
67
using Plots
78
end
89

10+
ENV["SKLEARN_JL_VERSION"] = "1.5.1"
11+
sklearn_jl_version = get(ENV, "SKLEARN_JL_VERSION", "1.8.0")
12+
@info "[in test/runtest.jl], (if running Github actions) this variable must match the scikit learn version in .github/workflows/tests.yml. SKLEARN_JL_VERSION: $(sklearn_jl_version)"
913

1014
function include_test(_module)
1115
println("Starting tests for $_module")

0 commit comments

Comments
 (0)