Skip to content

Commit 63a0926

Browse files
authored
fixed bug with 1d (#421)
* fixed bug with 1d * typo * typo * julia formatting removes [x;;] to [x] notation... * run format
1 parent 29beb8b commit 63a0926

2 files changed

Lines changed: 16 additions & 1 deletion

File tree

src/Utilities.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1163,7 +1163,7 @@ function create_noise_injector(
11631163
end
11641164

11651165
C = cov(prior)
1166-
m = reshape(mean(prior), :, 1)
1166+
m = (ndims(prior) > 1) ? reshape(mean(prior), :, 1) : fill(mean(prior), 1, 1)
11671167
E = Matrix(E)
11681168

11691169
enc_m = E * m + b

test/MarkovChainMonteCarlo/runtests.jl

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ using CalibrateEmulateSample.EnsembleKalmanProcesses
88
using CalibrateEmulateSample.MarkovChainMonteCarlo
99
const MCMC = MarkovChainMonteCarlo
1010
using CalibrateEmulateSample.ParameterDistributions
11+
const PD = ParameterDistributions
1112
using CalibrateEmulateSample.Emulators
1213
using CalibrateEmulateSample.DataContainers
1314
using CalibrateEmulateSample.Utilities
@@ -624,6 +625,20 @@ end
624625
@test noise_injector.use_noise # check for noise_injector_threshold
625626
@test noise_injector.scaling == 0.5
626627

628+
# check 1D
629+
input_dim = 1
630+
n_samples = 10
631+
prior_1d = constrained_gaussian("1d-check", 0, 1, -Inf, 5)
632+
in_data = PD.sample(prior_1d, n_samples)
633+
out_data = PD.sample(prior_1d, n_samples)
634+
io_pairs_1d = PairedDataContainer(in_data, out_data, data_are_columns = true)
635+
636+
# lossless encoding
637+
lossless_sch = create_encoder_schedule((minmax_scale(), "in"))
638+
initialize_and_encode_with_schedule!(lossless_sch, io_pairs_1d; prior_cov = cov(prior_1d))
639+
640+
noise_injector = create_noise_injector(lossless_sch, prior_1d, 0.0, 0.5)
641+
627642

628643
end
629644

0 commit comments

Comments
 (0)