Create a Forward map wrapper to more easily test pipelines without using an emulator#402
Merged
Conversation
Member
Author
|
Test fail from unrelated issue, waiting on merge of #403 |
Collaborator
|
After our meeting: I think this is useful as-is, but maybe we should add a warning if someone tries to pass in an input space encoder schedule, since they are currently unused. |
Member
Author
|
I've added a warning on creation of the FMW |
ArneBouillon
approved these changes
Feb 26, 2026
Co-authored-by: ArneBouillon <45404227+ArneBouillon@users.noreply.github.com>
Co-authored-by: ArneBouillon <45404227+ArneBouillon@users.noreply.github.com>
odunbar
force-pushed
the
orad/no-emulator
branch
from
March 3, 2026 01:11
c0de3d2 to
2fe016d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 94.20% 94.25% +0.04%
==========================================
Files 10 10
Lines 1813 1862 +49
==========================================
+ Hits 1708 1755 +47
- Misses 105 107 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored by @ArneBouillon
Purpose
Closes #401
See updated docs here
Content
ForwardMapWrapperwith constructorget_andpredictmethodsMISC
;error formlt_kwargsinpredict(emulator,...)Results from
Sinusoid/The key here is that "FM" is using the true forward map exactly replacing the emulator
