Re-organize data reduction - #371
Conversation
There was a problem hiding this comment.
Much cleaner!
I'm very glad that we will remove the anonymous functions with these changes. I will just comment now, and approve on failed runtests. These seem almost entirely based on functions that have been removed and are tested.
You may also need to check that there is not entry for the normalizations z2orig... etc. in docs/src/API/Utilities.jl or docs may have issues.
|
I have addressed some of your comments in the PR so there may be small conflicts - I will refrain from further changes until this is merged. (and will work on a Docs page) |
5388a99 to
6de2813
Compare
8c179b0 to
c8b927b
Compare
c8b927b to
8d33f8f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## orad/migrate-data-proc-to-new #371 +/- ##
=================================================================
+ Coverage 91.08% 91.12% +0.03%
=================================================================
Files 7 10 +3
Lines 1560 1544 -16
=================================================================
- Hits 1421 1407 -14
+ Misses 139 137 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR makes the following changes:
orig2zscoreandzscore2origfunctions, which were unused, are removed.Decorrelateris renamed toDecorrelatorcreate_encoder_schedule,initialize_and_encode_with_schedule!,encode_with_schedule, anddecode_with_schedule. My rationale for this is twofold.CES.Utilities._initialize_and_encode_data!.extract_datafunctions.I also started working towards
LikelihoodInformedprocessors by passing both structure matrices to the initialization code ofPDCPs. I didn't pass the observation yet, since I'm still looking for a clean way to add this to the pipeline.