feat(edmfx): add the momentum component of the horizontal SGS diffusive flux - #4658
Closed
haakon-e wants to merge 1 commit into
Closed
feat(edmfx): add the momentum component of the horizontal SGS diffusive flux#4658haakon-e wants to merge 1 commit into
haakon-e wants to merge 1 commit into
Conversation
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
haakon-e
force-pushed
the
he/edmfx-horizontal-momentum-diffusion
branch
from
July 9, 2026 01:08
4ab368f to
67c39de
Compare
…ve flux Apply the horizontal weak divergence of the SGS stress `τ = -2 K_u S`, with the full three-dimensional strain rate of the grid-mean velocity, to the grid-mean momentum: on cell centers for the horizontal wind and on cell faces for the vertical wind, mirroring the Smagorinsky-Lilly stress split by divergence direction. The eddy viscosity is the horizontal `K_u` from the TKE-based closure with the mixing length limited by the horizontal node spacing. Enabled under the existing `edmfx_sgs_horizontal_diffusive_flux` option; the vertical stress divergence remains with the vertical diffusion pathway. Add the corresponding TKE shear production from horizontal gradients, `2 ρ K_u S_h : S_h` with `S_h` the strain rate built from horizontal gradients only. The term is positive definite; the production from vertical gradients and its stencil are unchanged, mirroring the decoupled Smagorinsky-Lilly split in which each directional norm is built from that direction's gradients. Extend the tests: horizontally uniform velocity produces no momentum tendency, perturbed velocity produces one, the production term is positive definite under uniform TKE, and the single-column tendency is identically zero.
haakon-e
force-pushed
the
he/edmfx-horizontal-momentum-diffusion
branch
from
July 9, 2026 01:21
67c39de to
5865edb
Compare
Contributor
|
📖 Docs preview for this PR: https://clima.github.io/ClimaAtmos.jl/previews/PR4658/ |
Member
Author
|
Folded into #4657: the momentum stress and its TKE production counterpart land with the scalar fluxes so each PR is energetically self-contained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the horizontal weak divergence of the SGS stress
τ = -2 K_u S, with the full three-dimensional strain rate of the grid-mean velocity, to the grid-mean momentum: on cell centers for the horizontal wind and on cell faces for the vertical wind, mirroring the Smagorinsky–Lilly stress split by divergence direction. The eddy viscosity is the horizontalK_ufrom the TKE-based closure with the mixing length limited by the horizontal node spacing. Enabled under the existingedmfx_sgs_horizontal_diffusive_fluxoption; the vertical stress divergence remains with the vertical diffusion pathway.Adds the corresponding TKE shear production from horizontal gradients,
2 ρ K_u S_h : S_hwithS_hthe strain rate built from horizontal gradients only, so the resolved kinetic energy sink from the horizontal stress lands with its TKE source in the same PR. The term is positive definite; the production from vertical gradients and its stencil are unchanged, mirroring the decoupled Smagorinsky–Lilly split in which each directional norm is built from that direction's gradients.Extends the tests: horizontally uniform velocity produces no momentum tendency, perturbed velocity produces one, the production term is positive definite under uniform TKE, and the single-column tendency is identically zero.