refactor(diffusion): route EDMFX vertical diffusive fluxes through shared helpers - #4702
Open
haakon-e wants to merge 1 commit into
Open
refactor(diffusion): route EDMFX vertical diffusive fluxes through shared helpers#4702haakon-e wants to merge 1 commit into
haakon-e wants to merge 1 commit into
Conversation
haakon-e
force-pushed
the
he/edmf-vertical-diffusion-helpers
branch
from
July 16, 2026 23:11
748722a to
0c44640
Compare
Member
Author
|
@sajjadazimi This PR probably overlaps with what you're changing with EDMF now, so let me know which you'd prefer to merge first. |
Contributor
|
📖 Docs preview for this PR: https://clima.github.io/ClimaAtmos.jl/previews/PR4702/ |
haakon-e
force-pushed
the
he/edmf-vertical-diffusion-helpers
branch
from
July 22, 2026 19:01
0c44640 to
cef284c
Compare
haakon-e
force-pushed
the
he/edmf-3d-diffusion
branch
from
July 23, 2026 19:27
0decd0d to
2ff1125
Compare
haakon-e
force-pushed
the
he/edmf-vertical-diffusion-helpers
branch
from
July 23, 2026 20:00
cef284c to
f19fc7d
Compare
haakon-e
force-pushed
the
he/edmf-3d-diffusion
branch
from
July 23, 2026 20:08
2ff1125 to
a3d8e65
Compare
haakon-e
force-pushed
the
he/edmf-vertical-diffusion-helpers
branch
from
July 23, 2026 20:08
f19fc7d to
6276b13
Compare
haakon-e
force-pushed
the
he/edmf-3d-diffusion
branch
from
July 23, 2026 20:20
a3d8e65 to
38a6671
Compare
haakon-e
force-pushed
the
he/edmf-vertical-diffusion-helpers
branch
from
July 23, 2026 20:20
6276b13 to
e681161
Compare
haakon-e
force-pushed
the
he/edmf-3d-diffusion
branch
from
July 23, 2026 21:03
38a6671 to
8a2c65e
Compare
haakon-e
force-pushed
the
he/edmf-vertical-diffusion-helpers
branch
from
July 23, 2026 21:03
e681161 to
a282b25
Compare
haakon-e
force-pushed
the
he/edmf-3d-diffusion
branch
from
July 23, 2026 21:30
8a2c65e to
86f1665
Compare
haakon-e
force-pushed
the
he/edmf-vertical-diffusion-helpers
branch
from
July 23, 2026 21:30
a282b25 to
f261159
Compare
haakon-e
force-pushed
the
he/edmf-3d-diffusion
branch
from
July 23, 2026 21:32
86f1665 to
03fe0c8
Compare
haakon-e
force-pushed
the
he/edmf-vertical-diffusion-helpers
branch
from
July 23, 2026 21:32
f261159 to
a36d742
Compare
haakon-e
force-pushed
the
he/edmf-3d-diffusion
branch
from
July 23, 2026 22:17
03fe0c8 to
5ae7b0d
Compare
haakon-e
force-pushed
the
he/edmf-vertical-diffusion-helpers
branch
from
July 23, 2026 22:17
a36d742 to
77cb1db
Compare
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Jul 23, 2026
haakon-e
force-pushed
the
he/edmf-3d-diffusion
branch
from
July 24, 2026 17:40
5ae7b0d to
ecf3379
Compare
haakon-e
force-pushed
the
he/edmf-vertical-diffusion-helpers
branch
from
July 24, 2026 17:40
77cb1db to
2dc3e74
Compare
haakon-e
marked this pull request as ready for review
July 24, 2026 19:53
…ared helpers Route the grid-mean EDMFX SGS diffusive fluxes (total enthalpy, specific humidity, grid-scale tracers) through ᶜdiffusive_flux_divergenceᵥ and ᶠtotal_enthalpy_gradientᵥ, with the face coefficients, including the interfacial entrainment weighting, folded into the flux coefficient. The TKE flux keeps its dedicated divergence operator (nonzero bottom boundary value) and the momentum stress keeps its strain form. Tendencies are unchanged.
haakon-e
force-pushed
the
he/edmf-3d-diffusion
branch
from
July 25, 2026 22:22
ecf3379 to
fa5abe6
Compare
haakon-e
force-pushed
the
he/edmf-vertical-diffusion-helpers
branch
from
July 25, 2026 22:22
2dc3e74 to
1027e64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the consolidation from #4699 for the EDMFX vertical path: the grid-mean SGS diffusive fluxes in
edmfx_sgs_diffusive_flux_tendency!(total enthalpy via the dry static energy + water enthalpy decomposition, specific humidity, and grid-scale tracers with the α and interfacial-entrainment weighting folded into the flux coefficient) now use the sharedᶠtotal_enthalpy_gradientᵥandᶜdiffusive_flux_divergenceᵥ/ᶜdiffdivᵥhelpers.The TKE flux keeps its dedicated divergence operator, since its bottom boundary has a nonzero surface TKE flux, and the momentum stress keeps its strain-rate form.