Add a basic convolution function#2530
Draft
sjavis wants to merge 3 commits into
Draft
Conversation
sjavis
force-pushed
the
iccs/convolve_kernel
branch
from
July 6, 2026 14:50
2fc0b42 to
6b32f8e
Compare
Mikolaj-A-Kowalski
force-pushed
the
iccs/convolve_kernel
branch
from
July 20, 2026 10:28
6b32f8e to
63ba215
Compare
Contributor
|
I have rebased this development branch onto the current main. |
Quite horrible at the moment. Registers are spilling, efficiency is bad, interface is akward and I am not sure I am using the right way to iterate over the data layout. This commit will not survive. Expect it to be rebased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to create a generic convolution kernel to unify the vertical stencil operations into one. Closes #2539.
BandMatrixRowcallable for linear operators.column_convolve!that applies to scalars onlyFor later PRs:
local_geometryeither in the broadcasted expression or using a newLinearFormobject.column_convolve!column_convolve!into the rest of the codeCode quality checklist: