check for accepted values for accuracy in dcount,dcountif (#375)

* check for accepted values for accuracy in dcount,dcountif

* Added functional Testacse and fixed the error msg

Author: bhavnajindal

src/Parsers/Kusto/KustoFunctions/KQLAggregationFunctions.cpp

@@ -9,6 +9,7 @@
 namespace DB::ErrorCodes
 {
 extern const int NOT_IMPLEMENTED;
+extern const int BAD_ARGUMENTS;
 }
 
 namespace
@@ -26,12 +27,19 @@ uint mapPrecisionAccuracy(const std::optional<std::string> & accuracy)
 
     if (*accuracy == "0")
         return 12;
+    else if (*accuracy == "1")
+        return 14;
     else if (*accuracy == "2")
         return 16;
     else if (*accuracy == "3")
         return 17;
+    else if (*accuracy == "4")
+        return 18;
     else
-        return 14;
+        throw DB::Exception(
+            DB::ErrorCodes::BAD_ARGUMENTS,
+            "Accuracy argument must be a constant integer with value 0, 1, 2, 3 or 4 (0 = fast , 1 = default, 2 = accurate, 3 = extra accurate, 4 "
+            "= super accurate)");
 }
 }
 

tests/queries/0_stateless/02366_kql_summarize.sql

@@ -59,8 +59,10 @@ Customers | summarize MyAvg = avgif(Age, Age<40) by Occupation;
 Customers | summarize MySum = sumif(Age, Age<40) by Occupation;
 Customers | summarize dcount(Education);
 Customers | summarize dcount(Education, 2);
+Customers | summarize dcount(Education, 10);  -- { clientError 36 }
 Customers | summarize dcountif(Education, Occupation=='Professional');
 Customers | summarize dcountif(Education, Occupation=='Professional', 2);
+Customers | summarize dcountif(Education, Occupation=='Professional', -1); -- { clientError 36 }
 Customers | summarize count_ = count() by bin(Age, 10) | order by count_ asc;
 Customers | summarize job_count = count() by Occupation | where job_count > 0;
 Customers | summarize 'Edu Count'=count() by Education | sort by 'Edu Count' desc; -- { clientError 62 }