Sanitize Numeric, Licenses 2025-07-29#23
Merged
Conversation
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new numeric sanitization function and enables several previously commented-out input validations. The changes focus on improving input validation for numeric fields and environment variable sanitization.
- Implements
sanitize_numericfunction to validate and sanitize numeric inputs with optional range checking - Uncomments validation logic for several environment variables including
MEND_MAX_WAIT_TIME,MEND_POLL_INTERVAL,SBOM_SOURCE,SBOM_FORMAT, andMERGE - Adds comprehensive test coverage for the new
sanitize_numericfunction
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/sanitize.sh | Adds sanitize_numeric function and enables validation for numeric and enum environment variables |
| test/simple.bats | Adds 7 test cases covering various scenarios for the new sanitize_numeric function |
| license-mappings.json | Adds MIT license mapping for github.com/eapache/channels dependency |
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.