lib/common.sh, Licenses 2025-07-31#29
Merged
Merged
Conversation
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
juliojimenez
added
enhancement
github_actions
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase by extracting common utility functions and color definitions into a dedicated lib/common.sh module. This improves code organization and eliminates duplication.
- Moved color constants and logging functions from
entrypoint.shto a newlib/common.shfile - Updated
entrypoint.shto source the new common library - Modified test files to properly reference the new common library during testing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/common.sh | New file containing extracted color constants, logging functions, and cleanup utility |
| entrypoint.sh | Removed duplicated code and added source statement for common.sh |
| test/simple.bats | Added sed command to fix common.sh source path in test setup |
| test/advanced.bats | Added sed command to fix common.sh source path in test setup and updated comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.