Skip to content

Commit 0ce4caf

Browse files
Merge pull request #846 from ClickHouse/fix-hot-tab-crash-short-results
Fix Hot Run tab crash when a result file has fewer queries
2 parents b62a10f + 6f555d4 commit 0ce4caf

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

index.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -710,6 +710,7 @@ <h2>Detailed Comparison</h2>
710710
const combined_hot_share = 0.6;
711711

712712
function selectRun(timings, metric) {
713+
if (timings == null) return null;
713714
const cold_timing = timings[0];
714715
const hot_timing = (timings[1] !== null && timings[2] !== null ? Math.min(timings[1], timings[2]) : null);
715716

@@ -777,7 +778,7 @@ <h2>Detailed Comparison</h2>
777778

778779
const baseline_data = [...filtered_data[0].result.keys()].map(query_num =>
779780
[...Array(3).keys()].map(run_num =>
780-
Math.min(...filtered_data.filter(elem => !elem.fake).map(elem => elem.result[query_num][run_num]).filter(x => x != null))));
781+
Math.min(...filtered_data.filter(elem => !elem.fake).map(elem => elem.result[query_num]?.[run_num]).filter(x => x != null))));
781782

782783
const min_load_time = Math.min(...filtered_data.map(elem => elem.load_time).filter(x => x && x > 5));
783784
const min_data_size = Math.min(...filtered_data.map(elem => elem.data_size).filter(x => x && x > 1e9));

0 commit comments

Comments
 (0)