Conversation
Contributor
clickhouse-gh
Bot
added
pr-not-for-changelog
thevar1able
approved these changes
Apr 17, 2025
Member
Author
|
Failed tests look unrelated. |
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Stack unwinding for that zstd function was broken. This was causing some truncated stacks in query profiler. Here's a fix: ClickHouse/zstd#1 (pending upstream PR: facebook/zstd#4367 )
I made a fork of zstd because we didn't have one yet. This PR both applies the fix and updates zstd to latest version. Hope the update won't break anything.