Add nothing.h to the list of installed files#435
Merged
Conversation
Additionally, import it in client.h for consistency and to avoid manually importing it each time this column type is in use.
mshustov
approved these changes
Aug 13, 2025
slabko
force-pushed
the
install-nullable-columns
branch
from
513ca11 to
beb10fc
Compare
Contributor
|
IMO it would be a good idea to not only add unit-tests, but also installation tests, to prevent the whole class of the problems. Draft of the steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #432
Additionally, add a small test for the NothingColumn type to ensure it is not forgotten.