Add query plan cache page to the Operations sidebar#6459
Open
alexey-milovidov wants to merge 1 commit into
Open
Add query plan cache page to the Operations sidebar#6459alexey-milovidov wants to merge 1 commit into
alexey-milovidov wants to merge 1 commit into
Conversation
The new docs/en/operations/query-plan-cache.md page added in ClickHouse/ClickHouse#107125 is otherwise a floating page (no sidebar entry), which fails the Docs check.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Collaborator
|
@alexey-milovidov - to resolve the chicken/egg situation, the floating page has to be added to the exceptions file. I've created a PR to do just that: #6460 - This will allow the upstream docs check to pass. Once it does and the upstream PR is merged, then we can add it to the sidebar and remove the exception. I know, it's a bit of a pain! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
operations/query-plan-cacheto the Operations sidebar.The new page
docs/en/operations/query-plan-cache.mdintroduced in ClickHouse/ClickHouse#107125 is otherwise a floating page (no sidebar entry), which makes theDocs check(Build docusaurus) fail with:Related: ClickHouse/ClickHouse#107125