Add query-plan-cache to floating-pages exceptions#6460
Merged
Conversation
Unblocks the Docs check build for the page introduced in ClickHouse/ClickHouse#107125, which otherwise floats until a sidebar entry can be added once the page syncs in. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
operations/query-plan-cachetoplugins/floating-pages-exceptions.txtto break the chicken/egg between this docs repo and the ClickHouse repo.The page
docs/operations/query-plan-cache.mdis introduced in ClickHouse/ClickHouse#107125 and syncs into this repo. That creates a deadlock:sidebars.jsfirst (see Add query plan cache page to the Operations sidebar #6459) fails the build — the sidebar references a doc ID that doesn't exist here yet.Docs checkfloating-pages validation.The floating-pages plugin only globs files that actually exist, then skips anything in the exceptions list, so listing the path now is a safe no-op until the page syncs in.
Follow-up
Once
query-plan-cache.mdsyncs in, it'll be reachable by URL but absent from the sidebar nav. At that point the real sidebar entry (#6459 or equivalent) should land and this exception line should be removed. Coordinating with @alexey-milovidov on #6459 so the two don't collide.🤖 Generated with Claude Code