Skip to content

Commit 7d48053

Browse files
Clarify resolveTimeZone null contract and drop unused test import
Addresses Copilot review on PR #2877: - remove the unused java.util.TimeZone import from ClickHouseColumnTest (the test references resolveTimeZone(...)/getTimeZone() only, never the TimeZone type) - document resolveTimeZone's non-null tzName precondition; no behavior change (null is unreachable from all parse call sites, which pass a non-null replace("'","") result) Fixes: #2876
1 parent d6be12f commit 7d48053

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

clickhouse-data/src/main/java/com/clickhouse/data/ClickHouseColumn.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,8 @@ public enum DefaultValue {
140140
* converts the offset portion to a {@link ZoneOffset} before creating the
141141
* {@link TimeZone}, preserving the column's declared fixed offset.
142142
*
143-
* @param tzName timezone name as emitted in ClickHouse column type metadata
144-
* @return resolved {@link TimeZone}, never null
143+
* @param tzName non-null timezone name as emitted in ClickHouse column type metadata
144+
* @return resolved {@link TimeZone}; never null for a non-null {@code tzName}
145145
*/
146146
static TimeZone resolveTimeZone(String tzName) {
147147
if (tzName != null && tzName.startsWith("Fixed/UTC")) {

clickhouse-data/src/test/java/com/clickhouse/data/ClickHouseColumnTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import java.util.Collections;
66
import java.util.LinkedList;
77
import java.util.List;
8-
import java.util.TimeZone;
98

109
import org.testng.Assert;
1110
import org.testng.annotations.DataProvider;

0 commit comments

Comments
 (0)