@@ -63,69 +63,55 @@ jobs:
6363
6464 - **Public API shape** changed — return types, reader/result columns,
6565 serialization layout, anything that could silently break consumers.
66- - **Type system** — changes in `ClickHouse.Driver/Types/`, especially
67- `TypeConverter.cs`, type grammar parsers, or binary read/write paths.
68- Read AND write paths must usually move together; if only one side moves,
69- that's also a Concern.
70- - **Binary protocol / `Copy/`** — serialization layout or framing changes.
71- - **Connection pool / `Http/`** — lifecycle, pooling, streaming-vs-buffering
72- changes.
73- - **Concurrency** — new locks, atomics, `Interlocked`, `lock`,
74- `SemaphoreSlim`, `Volatile`, `Memory<T>` aliasing, or any change that
75- could introduce a deadlock or race.
76- - **Performance** — slow code in the hot path, new allocations, or any use
77- of reflection.
66+ - **Type system** — changes in `com.clickhouse.data` package.
67+ - **Readers** and **Writers** — changes in client-v2 readers and writers.
68+ - **Concurrency** — itroduction of new synchronization primitives, usnig non-threadsafe collections,
69+ synchronization on static object (big no-no).
70+ - **Performance** — using reflection, new object creation, synchronized collection in hot-path.
7871 - **Recursion** introduced into hot paths or applied to unbounded inputs
7972 (e.g. nested type parsing).
8073 - **Cross-module refactor** — touches three or more of `clickhouse-data/`, `clickhouse-client/`,
8174 `clickhouse-http-client/`, `clickhouse-jdbc/`, `clickhouse-r2dbc/`, `client-v2/`, `jdbc-v2/`.
8275 - **Security** — auth, certificate, credential, or trust-boundary handling
8376 change; potential SQL injection; logging that could leak PII or secrets
84- (URLs, headers, query parameters).
85- - **Major version bump** of a transport or crypto dependency (e.g.
86- `System.Net.Http`, `System.Security.Cryptography.*`, `BouncyCastle`) .
87- - **`FeatureSwitch` / `ClickHouseFeatureMap` ** — multi-version compatibility
77+ (URLs, headers, query parameters); input validation, especially when done with regexp or 3rd-party libraries;
78+ Usage of `String.format`;
79+ - **Major version bump** of any dependency .
80+ - **Missing Feature Flag ** — new feature in existing logic added without feature flag; multi-version compatibility
8881 surface.
8982 - **Permission change for the repo** — change of code owners, extracting
9083 GitHub variables, or any other unauthorized act.
9184 - **Changes to release workflow** — any change to the GitHub action for
9285 releasing a package.
86+ - **Large diff** - more than 400 lines of code or many changed files. Request split.
9387
9488 ## Medium risk
9589
9690 Any one (only if no High rule fired):
9791
98- - **Behavioral change in a single hot-path module** (`clickhouse-data/`, `clickhouse-client/`,
99- `clickhouse-http-client/`, `clickhouse-jdbc/`, `clickhouse-r2dbc/`, `client-v2/`, `jdbc-v2/`).
100- - **New connection-string setting**, or **changed default value** of an
101- existing setting.
102- - **Algorithm change with measurable performance implication** — flag a
103- benchmark request against `ClickHouse.Driver.Benchmark`.
104- - **Logging changes** — level promotion, hot-path logging, message-format
105- change.
106- - **Test-infra changes** that affect how the matrix runs.
92+ - **Behavioral change in a single hot-path module** (`clickhouse-data/`, `client-v2/`, `jdbc-v2/`).
93+ - **New connection-string setting**, or **changed default value** of an existing setting.
94+ - **Algorithm change with measurable performance implication** — flag a benchmark request against library.
95+ - **Logging changes** — level promotion, hot-path logging, message-format change.
96+ - **Test-infra changes** - when affects scope of tests (modules excluded, version excluded and no new added).
10797 - **Major version dependency bump.**
10898 - **Minor dependency bump** on a security-sensitive package.
109- - **Large diff** without obvious reason (~500+ LoC across ~15+ files).
110- - **Multi-framework guard** added (`#if NET10_0_OR_GREATER` etc.) on a
111- non-trivial code path.
11299 - **GitHub workflow changes** — any other changes in the `.github` directory.
113100
114101 ## Low risk
115102
116103 Default if neither set fires:
117104
118- - Doc-only / comment-only .
105+ - Updates in `docs/` AGENTS.md, CHANGELOG.md and similar files. No sources changed .
119106 - Minor patch dependency bump from Dependabot, CI green, no CVE in changelog.
120- - Isolated bug fix with a regression test in a non-hot-path file.
121- - Test-only additions (no source changes).
107+ - Test-only additions. No sources changed.
122108 - CI-only tweaks that don't change build/release output.
123109
124110 ## Reviewer-action policy
125111
126112 Emit one "Required reviewer action" line matching the assigned risk:
127113 - low — AI review with no comments → eligible for auto-merge per repo policy.
128114 - medium — at least one human reviewer.
129- - high — PR body must include an architectural description before review .
115+ - high — at least one human reviewer .
130116 secrets :
131117 ANTHROPIC_API_KEY : ${{ secrets.ANTHROPIC_API_KEY }}
0 commit comments