Udated GenericRecord javadoc. Fixed getStringArray() to return only arrays of strings

Author: chernser

client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java

@@ -25,6 +25,7 @@
 import java.time.ZoneOffset;
 import java.time.ZonedDateTime;
 import java.time.temporal.TemporalAmount;
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -295,19 +296,14 @@ public String[] getStringArray(String colName) {
         }
         if (value instanceof BinaryStreamReader.ArrayValue) {
             BinaryStreamReader.ArrayValue array = (BinaryStreamReader.ArrayValue) value;
-            int length = array.length;
-            String[] values = new String[length];
-            if (array.itemType.equals(String.class)) {
-                for (int i = 0; i < length; i++) {
-                    values[i] = (String) array.get(i);
-                }
+            if (array.itemType == String.class) {
+                return (String[]) array.getArray();
+            } else if (array.itemType == BinaryStreamReader.EnumValue.class) {
+                BinaryStreamReader.EnumValue[] enumValues = (BinaryStreamReader.EnumValue[]) array.getArray();
+                return Arrays.stream(enumValues).map(BinaryStreamReader.EnumValue::getName).toArray(String[]::new);
             } else {
-                for (int i = 0; i < length; i++) {
-                    Object item = array.get(i);
-                    values[i] = item == null ? null : item.toString();
-                }
+                throw new ClientException("Not an array of strings");
             }
-            return values;
         }
         throw new ClientException("Column is not of array type");
     }
@@ -482,7 +478,7 @@ public short[] getShortArray(int index) {
 
     @Override
     public String[] getStringArray(int index) {
-        return getPrimitiveArray(schema.columnIndexToName(index));
+        return getStringArray(schema.columnIndexToName(index));
     }
 
     @Override

client-v2/src/main/java/com/clickhouse/client/api/query/GenericRecord.java

@@ -248,11 +248,18 @@ public interface GenericRecord {
 
     short[] getShortArray(String colName);
 
+    /**
+     * Returns string array for columns {@code Array(String)}.
+     * This method doesn't make a conversion of other types to string.
+     *
+     * @param colName - column name
+     * @return String[]
+     */
     String[] getStringArray(String colName);
 
     /**
      * Reads column with name `colName` as an array of objects. Works for any array element type
-     * including non-primitive types like DateTime, Enum, UInt64 (BigInteger), FixedString, etc.
+     * including non-primitive types like DateTime, Enum, UInt64 (BigInteger), etc.
      * For nested arrays, inner ArrayValue elements are recursively converted to Object[].
      *
      * @param colName - column name

client-v2/src/test/java/com/clickhouse/client/datatypes/DataTypeTests.java

@@ -1332,10 +1332,6 @@ public void testGetObjectArrayMethods() throws Exception {
         Assert.assertEquals(uint64Arr[1], java.math.BigInteger.valueOf(200));
         Assert.assertEquals(uint64Arr[2], new java.math.BigInteger("18000044073709551615"));
 
-        // Array(UInt64) -> getStringArray converts via toString()
-        String[] uint64Strings = row1.getStringArray("uint64_arr");
-        Assert.assertEquals(uint64Strings, new String[]{"100", "200", "18000044073709551615"});
-
         // Array(Enum8) -> getObjectArray returns EnumValue[]
         Object[] enumArr = row1.getObjectArray("enum_arr");
         Assert.assertNotNull(enumArr);
@@ -1344,10 +1340,6 @@ public void testGetObjectArrayMethods() throws Exception {
         Assert.assertEquals(enumArr[0].toString(), "abc");
         Assert.assertEquals(enumArr[1].toString(), "cde");
 
-        // Array(Enum8) -> getStringArray returns enum names
-        String[] enumStrings = row1.getStringArray("enum_arr");
-        Assert.assertEquals(enumStrings, new String[]{"abc", "cde"});
-
         // Array(DateTime) -> getObjectArray returns ZonedDateTime[]
         Object[] dtArr = row1.getObjectArray("dt_arr");
         Assert.assertNotNull(dtArr);