Skip to content

Commit df1a530

Browse files
committed
Fixed sonar issues
1 parent 8ef9b31 commit df1a530

3 files changed

Lines changed: 9 additions & 1 deletion

File tree

client-v2/src/main/java/com/clickhouse/client/api/command/CommandSettings.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ public CommandSettings use(Session session) {
3434
return this;
3535
}
3636

37+
@Override
3738
public CommandSettings clearSession() {
3839
super.clearSession();
3940
return this;

jdbc-v2/src/main/java/com/clickhouse/jdbc/StatementImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import com.clickhouse.client.api.ClientConfigProperties;
44
import com.clickhouse.client.api.data_formats.ClickHouseBinaryFormatReader;
5-
import com.clickhouse.client.api.http.ClickHouseHttpProto;
65
import com.clickhouse.client.api.internal.ServerSettings;
76
import com.clickhouse.client.api.query.QueryResponse;
87
import com.clickhouse.client.api.query.QuerySettings;

jdbc-v2/src/test/java/com/clickhouse/jdbc/StatementTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import org.slf4j.Logger;
1010
import org.slf4j.LoggerFactory;
1111
import org.testng.Assert;
12+
import org.testng.SkipException;
1213
import org.testng.annotations.DataProvider;
1314
import org.testng.annotations.Test;
1415

@@ -749,6 +750,10 @@ private String waitForQueryId(StatementImpl stmt, int timeoutSeconds) throws Exc
749750

750751
@Test(groups = {"integration"})
751752
public void testCancelQueryWithSession() throws Exception {
753+
if (isCloud()) {
754+
throw new SkipException("Cloud + HTTP doesn't work well. Enough to test locally");
755+
}
756+
752757
// Regression test for #2690: cancelling a query that runs inside a session must not fail with
753758
// "Session is locked by a concurrent client" (SESSION_IS_LOCKED). The KILL QUERY request issued by
754759
// cancel() must not carry the session id of the query being cancelled.
@@ -788,6 +793,9 @@ public void testCancelQueryWithSession() throws Exception {
788793

789794
@Test(groups = {"integration"})
790795
public void testCancelInsertWithSession() throws Exception {
796+
if (isCloud()) {
797+
throw new SkipException("Cloud + HTTP doesn't work well. Enough to test locally");
798+
}
791799
// Regression test for #2690 covering a long-running INSERT executed inside a session.
792800
String tableName = getDatabase() + ".cancel_insert_with_session";
793801
String sessionId = "test-session-" + UUID.randomUUID();

0 commit comments

Comments
 (0)