Trigger Tableau TDVT in connectors on snapshot publish and release (CON-264)#2875
Draft
ShimonSte wants to merge 1 commit into
Draft
Trigger Tableau TDVT in connectors on snapshot publish and release (CON-264)#2875ShimonSte wants to merge 1 commit into
ShimonSte wants to merge 1 commit into
Conversation
Tableau users install the latest JDBC driver manually (no connector release cycle as a buffer), so driver regressions hit them immediately - 0.9.7 and 0.9.8 both broke Tableau connections. Each publish now fires a repository_dispatch (jdbc-snapshot / jdbc-release) into ClickHouse/connectors, where the tableau-tdvt workflow runs the TDVT suite against the published version and opens an issue on failure. The snapshot version is derived from the pom <revision> property because CHC_VERSION is commented out in nightly.yml. Both steps are continue-on-error so a dispatch failure can never fail a publish. Requires the CONNECTORS_DISPATCH_TOKEN secret (fine-grained PAT scoped to ClickHouse/connectors). Refs ClickHouse/connectors#71 (CON-264). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Repository collaborators can run the JMH benchmark suite against this PR by commenting: Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%): Only one benchmark run per PR is active at a time — issuing a new |
|
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
Contributor
|
Thank you for the PR! |
chernser
reviewed
Jun 11, 2026
| clickhouse-r2dbc/target/clickhouse*.jar | ||
| client-v2/target/client-v2*.jar | ||
| jdbc-v2/target/jdbc-v2*.jar | ||
| # Tableau users install the latest JDBC driver manually, so a release |
Contributor
There was a problem hiding this comment.
Release workflow does only push to staging and library may not be accessible for some time after that.
I think, we need somehow grab latest from maven central and test every week.
Idea is:
- if something broken - we should catch it on nightly
- if we doing a release and it is a release candidate - then latest should catch but actually we may trigger tests earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Appends a small
repository_dispatchstep tonightly.yml(eventjdbc-snapshot) andrelease.yml(eventjdbc-release) that notifiesClickHouse/connectorsafter each successful publish, so the TDVT suite runs against the exact published driver version. Implements the trigger half of ClickHouse/connectors#71 (CON-264).Why
Tableau users install the latest JDBC driver manually per our docs — there is no connector release cycle as a buffer, so driver regressions hit Tableau users in production immediately (0.9.7 broke on unknown config properties, 0.9.8 on
typeMappings/sslmode; 0.9.6 is the last known-good). The receiving workflow (connectors#76) runs TDVT on an ephemeral Windows runner and opens an issue titled with the offending version on failure.Notes
<revision>property (sed-extracted, verified →0.9.8-SNAPSHOT), becauseCHC_VERSIONis commented out innightly.yml.continue-on-error: true— a TDVT dispatch failure can never fail a publish/release.CONNECTORS_DISPATCH_TOKENsecret is added to this repo — fine-grained PAT, Contents read/write scoped toClickHouse/connectorsonly — and (2) the receiving workflow in connectors is live.Test plan
workflow_dispatchof Nightly → confirm aTableau TDVT (0.9.8-SNAPSHOT)run appears in connectors with the version in the payload.🤖 Generated with Claude Code