ci(workflows): refresh ClickHouse LTS pins (EOL 25.3 → 26.3)#2959
Open
polyglotAI-bot wants to merge 1 commit into
Open
ci(workflows): refresh ClickHouse LTS pins (EOL 25.3 → 26.3)#2959polyglotAI-bot wants to merge 1 commit into
polyglotAI-bot wants to merge 1 commit into
Conversation
ClickHouse 25.3 LTS is effectively EOL. Roll the older pinned LTS forward to 26.3 (current second-newest LTS), and move the single-version env pins used by non-matrix jobs from 25.3 to 25.8 — the older/more battle-tested of the two pinned LTS, matching this repo's long-standing convention (env vars have always tracked the older LTS; see commit 76c335d). - build.yml: test matrix ["25.3","25.8","latest"] -> ["25.8","26.3","latest"] (x3); PREFERRED_LTS_VERSION "25.3" -> "25.8" - analysis.yml: PREFERRED_LTS_VERSION "25.3" -> "25.8" - nightly.yml: CH_VERSION "25.3" -> "25.8" - release.yml: CH_VERSION "25.3" -> "25.8" CI-only change; no client behavior change (no CHANGELOG / version bump). Approved by @mshustov per the AGENTS.md CI-change policy. Closes #2954 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refreshes the pinned ClickHouse LTS versions used by GitHub Actions workflows, dropping the effectively EOL 25.3 and moving the workflows to the current LTS pair while keeping latest in the matrix.
Changes:
- Update
build.ymlClickHouse test matrices from["25.3","25.8","latest"]to["25.8","26.3","latest"]. - Bump single-version workflow pins (
PREFERRED_LTS_VERSION/CH_VERSION) from25.3to25.8in non-matrix workflows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/build.yml | Updates LTS matrix pins and PREFERRED_LTS_VERSION to remove 25.3 and add 26.3 while keeping 25.8 + latest. |
| .github/workflows/analysis.yml | Updates PREFERRED_LTS_VERSION from 25.3 to 25.8 for analysis jobs. |
| .github/workflows/nightly.yml | Updates CH_VERSION from 25.3 to 25.8 for nightly publishing jobs. |
| .github/workflows/release.yml | Updates CH_VERSION from 25.3 to 25.8 for release publishing jobs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI/maintenance chore — refresh the pinned ClickHouse LTS versions used across the workflows. ClickHouse 25.3 LTS is effectively EOL, so this rolls the older pinned LTS forward to 26.3 (current second-newest LTS) and moves the single-version env pins used by non-matrix jobs from
25.3to25.8.Raised for go-ahead in #2954 per the repository's CI-change policy (AGENTS.md: "Do not modify CI workflow files (
.github/workflows/**). CI changes are restricted; raise it with the user first."). Approved by @mshustov (assigned + "please take this").Rationale / design
latest:["25.3","25.8","latest"]→["25.8","26.3","latest"].latestalready covers the newest stable (26.7), so the applicable change is refreshing the stale LTS pins, not adding a 26.7 pin.PREFERRED_LTS_VERSION/CH_VERSION(the single version used by non-matrix jobs) →25.8, the older/more battle-tested of the two pinned LTS. This matches the repo's long-standing convention — these env vars have always tracked the older LTS (24.3for[24.3,24.8];25.3for[25.3,25.8]; unified in commit76c335d0). (The alternative —26.3, newest LTS — was offered on CI: refresh ClickHouse version pins — roll EOL 25.3 LTS → 26.3 (go-ahead requested per AGENTS.md CI policy) #2954.)Changes
build.yml: test matrix["25.3","25.8","latest"]→["25.8","26.3","latest"](×3 jobs);PREFERRED_LTS_VERSION"25.3"→"25.8"analysis.yml:PREFERRED_LTS_VERSION"25.3"→"25.8"nightly.yml:CH_VERSION"25.3"→"25.8"release.yml:CH_VERSION"25.3"→"25.8"Left unchanged (intentional): the
["cloud"]matrix, the commented-out block inbuild.yml(references$PREFERRED_LTS_VERSION, auto-follows),run_examples.yml(already defaults to25.8),test_head.yml(head).Validation
25.3no longer appears anywhere under.github/workflows/, and no version-specific conditionals key off25.3.clickhouse/clickhouse-server:26.3and:25.8both exist.Notes
CHANGELOGentry and no version bump.Closes #2954