Add CustomPrivateDnsMapping and customPrivateDnsMappings field#213
Open
sdairs wants to merge 1 commit into
Open
Add CustomPrivateDnsMapping and customPrivateDnsMappings field#213sdairs wants to merge 1 commit into
sdairs wants to merge 1 commit into
Conversation
Closes the OpenAPI drift gap reported in #212. The live spec adds a new CustomPrivateDnsMapping schema and a customPrivateDnsMappings array on both CreateReversePrivateEndpoint and ReversePrivateEndpoint; without this change, DNS-mapping data was being silently dropped on deserialization. The new fields are documented as optional but the description heuristic in resolve-field-requirements.py keys on the literal "Optional" prefix, so "Private Preview. Optional list..." misclassifies as required. Model the fields as Option<T> and add OPTIONALITY_EXEMPTIONS entries so the spec-coverage test recognises the intentional divergence. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #212.
clickhouse_cloud_openapi.json) to pick up the newCustomPrivateDnsMappingschema and the newcustomPrivateDnsMappingsarrays onCreateReversePrivateEndpointandReversePrivateEndpoint.CustomPrivateDnsMappingRust type inmodels.rs.custom_private_dns_mappings: Option<Vec<CustomPrivateDnsMapping>>to bothCreateReversePrivateEndpointandReversePrivateEndpoint.OPTIONALITY_EXEMPTIONSentries sospec_coverage_testaccepts the optional modeling.The three new fields are documented as optional but the description heuristic in
scripts/resolve-field-requirements.pyonly matches the literal"Optional"prefix — descriptions like"Private Preview. Optional list of..."get misclassified as required. The fields are modelled asOption<T>to match real API behavior, with exemption entries explaining the divergence.Test plan
cargo build(workspace)cargo clippy --workspace --all-targetscargo test -p clickhouse-cloud-api --libcargo test -p clickhouse-cloud-api --test spec_coverage_test(snapshot +--ignoredlive)cargo test -p clickhousectl(37 request-shape tests)python3 scripts/check-openapi-drift.pyreports zero drift🤖 Generated with Claude Code