🔒 fix: Read-Only Edit Dialogs Without Manage Permission#11
Merged
dustinhealy merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
When a user doesn't have MANAGE_ROLES or MANAGE_GROUPS capability, the name/description fields are now disabled and read-only, permission toggles are disabled, and the save button is disabled.
danny-avila
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a user lacks
MANAGE_ROLESorMANAGE_GROUPScapability, the edit role/group dialogs still allowed interacting with name and description fields, permission toggles, and the save button. This was misleading — the server would reject the mutation, but the UI didn't communicate that the user couldn't make changes.Now when
!canManage:disabled+readOnlyChange Type
Testing
MANAGE_ROLES/MANAGE_GROUPS→ open an edit dialog → confirm fields are editable and save worksMANAGE_ROLESgrant from the user's role → refresh → open a role edit dialog → confirm:cursor-not-allowedand can't be typed intoMANAGE_GROUPSChecklist