Merged
Conversation
Previously search filtered only the current server page (50 of 200+) and didn't reset the page number, causing search and pagination to fight. Now fetches all roles via allRolesQueryOptions and does client-side filtering + pagination with page reset on search. The roles list API does not support a search parameter (unlike groups), so client-side filtering is the correct approach here.
danny-avila
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Roles search and pagination were fighting each other. Search filtered client-side on the current server page only (e.g. 50 of 200+ roles), and the page number didn't reset — so typing a search term while on page 5 would show zero results even when matches existed on other pages.
Now
RolesTabfetches all roles viaallRolesQueryOptions(capped at 200 by the backend) and does client-side filtering + pagination with page reset on search input change.The LibreChat roles list API (
GET /api/admin/roles) does not support asearchquery parameter (unlike groups), so client-side filtering is the correct approach here.Change Type
Testing
Checklist