Stop truncating long Telegram replies in format_response#172
Open
serxa wants to merge 1 commit into
Open
Conversation
serxa
changed the title
format_response() truncated any text over MAX_MSG_LEN and appended a "... (truncated)" marker. But send() already splits outgoing text into MAX_MSG_LEN-sized chunks delivered as sequential messages, so truncating first permanently dropped the tail of long replies. Return the text unchanged and let send() handle chunking.
serxa
force-pushed
the
serxa/telegram-no-truncate-long-replies
branch
from
ef9f823 to
801614a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
format_response()truncated any reply longer thanMAX_MSG_LEN, appending a"... (truncated)"marker. Butsend()already splits outgoing text intoMAX_MSG_LEN-sized chunks and delivers them as sequential messages — so the truncation ran first and permanently dropped the tail of long replies.How
Return the text unchanged from
format_response()and letsend()do the chunking, so long replies are delivered in full across multiple messages.Notes
Independent of #171 (touches a different region of the same file; no conflict). No Telegram/channel tests in the suite.