Conversation
serprex
force-pushed
the
binary-c
branch
11 times, most recently
from
17d92e9 to
500c05b
Compare
theory
reviewed
May 23, 2026
clickhouse-c is an experimental clickhouse library focused on minimalism, allowing for proper compatibility reusing postgres allocator
serprex
commented
May 23, 2026
| return false; | ||
| } | ||
|
|
||
| /* dynamic buffer for raw bytes; palloc-backed, freed by context delete */ |
Member
Author
There was a problem hiding this comment.
could use StringInfoData if we're okay choking on blocks larger than 1GB
serprex
commented
May 23, 2026
|
|
||
| struct ch_binary_state | ||
| { | ||
| MemoryContext cxt; |
Member
Author
There was a problem hiding this comment.
@theory I know you've pointed out that this sort of thing belongs in a library, but hooking into MemoryContext / ereport / etc will hopefully convince you of the cleanliness keeping this out of clickhouse-c. maybe we need a src/binary/ with binary/binary_decode/binary_encode/binary_connection/select/insert/...
serprex
commented
May 23, 2026
| continue; | ||
| } | ||
|
|
||
| /* Linear search current dict (skip slot 0 for Nullable). */ |
Member
Author
There was a problem hiding this comment.
this might be trusting user to understand what "low cardinality" means too much
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eradicates #241