Skip to content

Fix #4663 - changelog enforcement of unreleased section specifically#6216

Draft
dnil wants to merge 55 commits into
mainfrom
test_changelog_enforcer_section
Draft

Fix #4663 - changelog enforcement of unreleased section specifically#6216
dnil wants to merge 55 commits into
mainfrom
test_changelog_enforcer_section

Conversation

@dnil
Copy link
Copy Markdown
Member

@dnil dnil commented Apr 20, 2026

This PR adds a functionality or fixes a bug.

Test changelog enforcement of a particular section of the changelog.

Testing

With changes only to an old, released section:
Screenshot 2026-04-20 at 12 51 36

And with a proper change to the unreleased section

Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. First book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout@<name_of_currently_deployed_branch>
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by
  • tests executed by

@dnil dnil marked this pull request as draft April 20, 2026 10:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.04%. Comparing base (ee24209) to head (265ebd2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6216      +/-   ##
==========================================
+ Coverage   84.03%   84.04%   +0.01%     
==========================================
  Files         346      346              
  Lines       21664    21685      +21     
==========================================
+ Hits        18206    18226      +20     
- Misses       3458     3459       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@northwestwitch northwestwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍🏻

steps:
- uses: actions/checkout@v6
- uses: dangoslen/changelog-enforcer@v3
- uses: dnil/changelog-enforcer@v3
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, still draft here! 😊 Thank Co-Pilot. It is still a little bugged, and on node 20 rather than 24, so will do a few updates. Might pause this for a bit, since js isn't quite my forte, and my co-pilot allowance is apparently not infinite. 😆 It's a fun experiment anyway. Co-pilot feels pretty much like Codex, but more GitHub and editor integrated.

Copy link
Copy Markdown
Member

@northwestwitch northwestwitch Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, still draft here! 😊 Thank Co-Pilot. It is still a little bugged, and on node 20 rather than 24, so will do a few updates. Might pause this for a bit, since js isn't quite my forte, and my co-pilot allowance is apparently not infinite. 😆 It's a fun experiment anyway. Co-pilot feels pretty much like Codex, but more GitHub and editor integrated.

Ah OK, I gave you the benefit of having your own action. 😆

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, thank you. Most of the work is from the original authors: I just forked it and had ample model help adding one more option. I realised I have not properly tried out the later models with these sandbox environments. It's clearly better: context and iteration matters. The idea of trial-and-error until the model passes the code tests is not bad. Still far from perfect, but hey, so is almost everyone.

@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automation: check CHANGELOG changes for latest version/unreleased

2 participants