[#69] 코드 리뷰 반영: 에러 처리 및 코드 품질 개선

Author: Hrepay

Codive/Features/Feed/Presentation/Add/View/PhotoTagView.swift

@@ -65,6 +65,14 @@ struct PhotoTagView: View {
             .enableSwipeBack()
         }
         .ignoresSafeArea(.all, edges: .bottom)
+        .alert("오류", isPresented: Binding(
+            get: { viewModel.errorMessage != nil },
+            set: { if !$0 { viewModel.errorMessage = nil } }
+        )) {
+            Button("확인", role: .cancel) {}
+        } message: {
+            Text(viewModel.errorMessage ?? "")
+        }
     }
 }
 

Codive/Features/Feed/Presentation/Add/ViewModel/PhotoTagViewModel.swift

@@ -23,6 +23,7 @@ final class PhotoTagViewModel: ObservableObject {
     @Published var selectedProducts: Set<Int> = []
     @Published var clothTags: [ClothTag] = []
     @Published var clothItems: [ProductItem] = []
+    @Published var errorMessage: String?
 
     let allPhotos: [SelectedPhoto]
     private let navigationRouter: NavigationRouter
@@ -68,14 +69,18 @@ final class PhotoTagViewModel: ObservableObject {
     }
 
     // MARK: - Methods
+    // TODO: 코디 완성 후 태그하기 진입 시, 해당 코디에 사용된 clothId 목록을 전달받아
+    // isTodayCloth: true 설정 + 자동 선택 처리 필요 (백엔드 API 필드 추가 or 클라이언트 처리)
     func fetchClothItems() async {
+        errorMessage = nil
         do {
             clothItems = try await fetchClothItemsUseCase.execute(category: selectedCategory)
         } catch {
             #if DEBUG
             print("[PhotoTag] Failed to fetch cloth items: \(error)")
             #endif
             clothItems = []
+            errorMessage = "옷 목록을 불러오지 못했습니다"
         }
     }
 

Codive/Features/Feed/Presentation/FeedDetail/View/FeedDetailView.swift

@@ -173,12 +173,10 @@ struct FeedDetailView: View {
                 await viewModel.loadFeedDetail()
             }
         }
-        .sheet(isPresented: $viewModel.isLikesSheetPresented, onDismiss: {
-            viewModel.isLikesSheetPresented = false
-        }, content: {
+        .sheet(isPresented: $viewModel.isLikesSheetPresented) {
             FeedLikesListView(viewModel: viewModel)
                 .presentationDetents([.medium, .large])
-        })
+        }
         .sheet(isPresented: Binding(
             get: { navigationRouter.sheetDestination != nil && isCommentSheet(navigationRouter.sheetDestination) },
             set: { if !$0 { navigationRouter.dismissSheet() } }

Codive/Features/Feed/Presentation/MainFeed/View/FeedView.swift

@@ -94,7 +94,7 @@ struct FeedView: View {
             }
             .presentationDetents([.height(500)])
         }
-        .onAppear {
+        .task {
             viewModel.loadFeedsIfNeeded()
         }
     }

Codive/Features/Feed/Presentation/MainFeed/ViewModel/FeedViewModel.swift

@@ -126,12 +126,11 @@ final class FeedViewModel: ObservableObject {
             feeds = result.feeds
             nextCursor = result.nextCursor
             hasMorePages = result.hasNext
-        } catch {
+        } catch is CancellationError {
             // Task 취소 시 기존 데이터 유지
-            guard !Task.isCancelled else {
-                isLoading = false
-                return
-            }
+            isLoading = false
+            return
+        } catch {
             errorMessage = "Feed를 불러오는데 실패했습니다: \(error.localizedDescription)"
             feeds = []
         }

Codive/Features/Profile/MyProfile/Data/ProfileAPIService+Extensions.swift

@@ -18,7 +18,6 @@ extension ProfileAPIService {
         switch response {
         case .ok(let okResponse):
             let data = try await Data(collecting: okResponse.body.any, upTo: .max)
-            let jsonDecoder = JSONDecoderFactory.makeAPIDecoder()
 
             let decoded = try jsonDecoder.decode(Components.Schemas.BaseResponseListFavoriteCoordinateResponse.self, from: data)
 
@@ -45,7 +44,6 @@ extension ProfileAPIService {
         switch response {
         case .ok(let okResponse):
             let data = try await Data(collecting: okResponse.body.any, upTo: .max)
-            let jsonDecoder = JSONDecoderFactory.makeAPIDecoder()
 
             let decoded = try jsonDecoder.decode(Components.Schemas.BaseResponseListFavoriteCoordinateResponse.self, from: data)