[#60] 코드 정리

#60

Author: Funital

Codive/Features/Home/Data/Services/HomeAPIService.swift

@@ -42,10 +42,10 @@ protocol HomeAPIServiceProtocol {
 }
 
 final class HomeAPIService: HomeAPIServiceProtocol {
-
+    
     private let client: Client
     private let jsonDecoder: JSONDecoder
-
+    
     init(tokenProvider: TokenProvider = KeychainTokenProvider()) {
         self.client = CodiveAPIProvider.createClient(
             middlewares: [CodiveAuthMiddleware(provider: tokenProvider)]
@@ -58,8 +58,8 @@ extension HomeAPIService {
 
     func fetchRecommendCategoryCloth(lastClothId: Int64?, size: Int32, categoryId: Int64, season: [Season]) async throws -> HomeCategoryResponseDTO {
         guard let firstSeason = season.first else {
-                throw HomeAPIError.invalidResponse
-            }
+            throw HomeAPIError.invalidResponse
+        }
         let seasonPayload = mapSeasonToQueryParam(firstSeason)
 
         let input = Operations.Cloth_recommendCategoryClothes.Input(
@@ -71,7 +71,7 @@ extension HomeAPIService {
         switch response {
         case .ok(let okResponse):
             let data = try await Data(collecting: okResponse.body.any, upTo: .max)
-
+            
             let decoded = try jsonDecoder.decode(Components.Schemas.BaseResponseSliceResponseClothRecommendListResponse.self, from: data)
 
             let content: [HomeCategoryResponseItem] = decoded.result?.content?.map { item -> HomeCategoryResponseItem in
@@ -119,11 +119,11 @@ extension HomeAPIService {
         switch response {
         case .ok(let okResponse):
             let data = try await Data(collecting: okResponse.body.any, upTo: .max)
-
+            
             let decoded = try jsonDecoder.decode(Components.Schemas.BaseResponseListCoordinateDetailsListResponse.self, from: data)
 
             let items = decoded.result ?? []
-
+            
             return items.map { item in
                 FetchTodayCoordinateDetailsResponseDTO(
                     coordinateClothId: item.coordinateClothId ?? 0,
@@ -181,10 +181,10 @@ extension HomeAPIService {
         let requestBody = Components.Schemas.TemperatureNotificationRequest(
             temperature: request.temperature
         )
-
+        
         let input = Operations.sendTemperatureNotification.Input(body: .json(requestBody))
         let response = try await client.sendTemperatureNotification(input)
-
+        
         switch response {
         case .ok:
             return
@@ -211,20 +211,20 @@ extension HomeAPIService {
         )
         let input = Operations.Coordinate_createDailyCoordinate.Input(body: .json(requestBody))
         let response = try await client.Coordinate_createDailyCoordinate(input)
-
+        
         switch response {
         case .ok(let okResponse):
             let data = try await Data(collecting: okResponse.body.any, upTo: .max)
             let decoded = try jsonDecoder.decode(
                 Components.Schemas.BaseResponseCoordinateCreateResponse.self,
                 from: data
             )
-
+            
             guard let coordinateId = decoded.result?.coordinateId else {
                 throw HomeAPIError.invalidResponse
             }
             return CreateTodayCoordinateResponseDTO(coordinateId: coordinateId)
-
+            
         case .undocumented(statusCode: let code, _):
             throw HomeAPIError.serverError(statusCode: code, message: "오늘의 코디 생성 실패")
         }
@@ -261,40 +261,7 @@ extension HomeAPIService {
         }
     }
 
-//    func patchUpdateCoordinates(coordinateId: Int64, request: EditCoordinateRequestDTO) async throws {
-//        let requestBody = Components.Schemas.CoordinateUpdateRequest(
-//            coordinateImageUrl: request.coordinateImageUrl,
-//            name: request.name,
-//            memo: request.memo,
-//            payloads: request.payloads?.map {
-//                Components.Schemas.CoordinateUpdateRequestPayload(
-//                    clothId: $0.clothId,
-//                    locationX: $0.locationX,
-//                    locationY: $0.locationY,
-//                    ratio: $0.ratio,
-//                    degree: $0.degree,
-//                    order: Int32($0.order)
-//                )
-//            }
-//        )
-//        
-//        let input = Operations.Coordinate_updateCoordinate.Input(
-//            path: .init(coordinateId: coordinateId),
-//            body: .json(requestBody)
-//        )
-//        let response = try await client.Coordinate_updateCoordinate(input)
-//        
-//        switch response {
-//        case .ok:
-//            return
-//        case .undocumented(statusCode: let code, _):
-//            throw LookBookAPIError.serverError(statusCode: code, message: "코디 수정 실패")
-//        }
-//    }
     func patchUpdateCoordinates(coordinateId: Int64, request: EditCoordinateRequestDTO) async throws {
-        print("--------------------------------------------------")
-        print("🚀 [API Request] PATCH Coordinate - ID: \(coordinateId)")
-        
         let requestBody = Components.Schemas.CoordinateUpdateRequest(
             coordinateImageUrl: request.coordinateImageUrl,
             name: request.name,
@@ -310,46 +277,24 @@ extension HomeAPIService {
                 )
             }
         )
-
+        
         let input = Operations.Coordinate_updateCoordinate.Input(
             path: .init(coordinateId: coordinateId),
             body: .json(requestBody)
         )
-        
         let response = try await client.Coordinate_updateCoordinate(input)
 
         switch response {
         case .ok:
-            print("✅ [API Success] 코디 수정 성공")
             return
-            
-        case .undocumented(statusCode: let code, let payload):
-            print("❌ [API Error] Status Code: \(code)")
-            
-            // HTTPBody에서 데이터를 추출하여 문자열로 변환하는 로직
-            var errorBody: String = "No body content"
-            if let body = payload.body {
-                do {
-                    // body를 Data로 변환한 뒤 String으로 변환
-                    let data = try await Data(collecting: body, upTo: 1024 * 1024) // 최대 1MB
-                    if let decodedString = String(data: data, encoding: .utf8) {
-                        errorBody = decodedString
-                    }
-                } catch {
-                    errorBody = "Failed to decode error body: \(error.localizedDescription)"
-                }
-            }
-            
-            print("⚠️ Server Error Message: \(errorBody)")
-            print("--------------------------------------------------")
-            
-            throw LookBookAPIError.serverError(statusCode: code, message: "코디 수정 실패: \(errorBody)")
+        case .undocumented(statusCode: let code, _):
+            throw LookBookAPIError.serverError(statusCode: code, message: "코디 수정 실패")
         }
     }
 }
 
 private extension HomeAPIService {
-
+    
     func mapSeasonToQueryParam(
         _ season: Season
     ) -> Operations.Cloth_recommendCategoryClothes.Input.Query.seasonPayload {
@@ -385,7 +330,7 @@ enum HomeAPIError: LocalizedError {
     case s3UploadFailed(statusCode: Int)
     case noClothIdsReturned
     case serverError(statusCode: Int, message: String)
-
+    
     var errorDescription: String? {
         switch self {
         case .presignedUrlMismatch:

Codive/Features/Home/Presentation/View/HomeNoCodiView.swift

@@ -12,7 +12,7 @@ struct HomeNoCodiView: View {
     // MARK: - Properties
     @ObservedObject var viewModel: HomeViewModel
     @State private var draggingItem: CategoryEntity?
-
+    
     // MARK: - Body
     var body: some View {
         VStack(spacing: 0) {
@@ -27,15 +27,11 @@ struct HomeNoCodiView: View {
         }
         .onAppear {
             viewModel.onAppear()
-//            Task {
-//                await viewModel.loadRecommendCategoryClothList()
-//            }
             Task {
-                            // 이미 카테고리 아이템이 있다면(수정 모드 진입 등) 새로 로드하지 않음
-                            if viewModel.clothItemsByCategory.isEmpty {
-                                await viewModel.loadRecommendCategoryClothList()
-                            }
-                        }
+                if viewModel.clothItemsByCategory.isEmpty {
+                    await viewModel.loadRecommendCategoryClothList()
+                }
+            }
         }
     }
 }
@@ -68,41 +64,22 @@ private extension HomeNoCodiView {
         .padding(.bottom, 16)
     }
 
-//    var codiClothList: some View {
-//        ScrollView(.vertical, showsIndicators: false) {
-//            VStack(spacing: 16) {
-//                ForEach(viewModel.activeCategories) { category in
-//                    let clothItems = viewModel.clothItemsByCategory[category.id] ?? []
-//                    
-//                    CodiClothView(
-//                        title: category.title,
-//                        items: clothItems,
-//                        isEmptyState: clothItems.isEmpty
-//                    ) { newIndex in
-//                        viewModel.updateSelectedIndex(for: category.id, index: newIndex)
-//                    }
-//                    .id("\(category.id)_\(clothItems.count)")
-//                    .background(Color.white)
-//                    .cornerRadius(15)
     var codiClothList: some View {
         ScrollView(.vertical, showsIndicators: false) {
             VStack(spacing: 16) {
                 ForEach(viewModel.activeCategories, id: \.id) { category in
-                    // 1. 필요한 데이터를 안전하게 추출 (타입 명시)
                     let items: [HomeClothEntity] = viewModel.clothItemsByCategory[category.id] ?? []
                     let selectedIdx: Int = viewModel.selectedIndicesByCategory[category.id] ?? 0
 
-                    // 2. 뷰를 생성할 때 고유 ID는 category.id만 사용 (스크롤 안정성 핵심)
                     CodiClothView(
                         title: category.title,
                         items: items,
                         selectedIndex: selectedIdx,
-                        isEmptyState: items.isEmpty,
-                        onIndexChanged: { newIndex in
-                            viewModel.updateSelectedIndex(for: category.id, index: newIndex)
-                        }
-                    )
-                    .id(category.id) // 여기에 selectedIdx를 포함하면 스크롤 시 뷰가 튀게 됩니다.
+                        isEmptyState: items.isEmpty
+                    ) { newIndex in
+                        viewModel.updateSelectedIndex(for: category.id, index: newIndex)
+                    }
+                    .id(category.id)
                     .background(Color.white)
                     .cornerRadius(15)
                     .onDrag {
@@ -177,14 +154,14 @@ struct CategoryDropDelegate: DropDelegate {
             }
         }
     }
-
+    
     func performDrop(info: DropInfo) -> Bool {
         withAnimation(.easeInOut) {
             draggingItem = nil
         }
         return true
     }
-
+    
     func dropUpdated(info: DropInfo) -> DropProposal? {
         return DropProposal(operation: .move)
     }

Codive/Features/Home/Presentation/ViewModel/CodiBoardViewModel.swift

@@ -57,21 +57,11 @@ final class CodiBoardViewModel: ObservableObject {
     }
 
     // MARK: - Navigation
-    
-    /// 이전 화면으로 이동
-//    func handleBackTap() {
-//        if homeViewModel?.todayCodiPreview != nil {
-//                    homeViewModel?.hasCodi = true
-//                }
-//        navigationRouter.navigateBack()
-//    }
     func handleBackTap() {
-        // 수정 중이었거나 기존 데이터가 있다면 화면 상태를 HasCodi로 복구
         if let homeVM = homeViewModel {
             if homeVM.todayCodiPreview != nil {
                 homeVM.hasCodi = true
             }
-            // 수정 모드 플래그 해제 (다음에 새로 들어올 때를 위해)
             homeVM.isEditingExistingCodi = false
         }
         navigationRouter.navigateBack()