Skip to content

Commit 3f9db78

Browse files
authored
[refactor/#291] 배경 사진 삭제 (#293)
* refactor: 배경 사진 삭제 * refactor: 남은 clokeyId 삭제 * chore: enum과 listner 테스트 커버리지 제외 --------- Co-authored-by: 나용준 <141994188+youngJun99@users.noreply.github.com>
1 parent 733896b commit 3f9db78

19 files changed

Lines changed: 29 additions & 77 deletions

File tree

build.gradle

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ sonarqube {
2525
property 'sonar.test.inclusions', '**/*Test.java'
2626
property 'sonar.exclusions', '**/test/**, **/Q*.java, **/*Doc*.java, **/resources/** ,**/*Application*.java , **/*Config*.java,' +
2727
'**/*Dto*.java, **/*Request*.java, **/*Response*.java ,**/*Exception*.java ,**/*ErrorCode*.java, **/*Util*.java, **/*Filter*.java,' +
28-
'**/*Handler*.java, **/*Validator*.java, **/*Principal*.java, **/*Properties*.java, **/clokey-domain/**'
28+
'**/*Handler*.java, **/*Validator*.java, **/*Principal*.java, **/*Properties*.java, **/*Listener*.java, **/enums/**, **/clokey-domain/**'
2929
property 'sonar.java.coveragePlugin', 'jacoco'
3030
}
3131
}
@@ -75,7 +75,9 @@ subprojects {
7575
"**/*Request*",
7676
"**/*Response*",
7777
"**/*Interceptor*",
78-
"**/*Exception*"
78+
"**/*Exception*",
79+
"**/*Listener*",
80+
"**/enums/**"
7981
] + QDomains)
8082
})
8183
)

clokey-api/src/main/java/org/clokey/domain/auth/service/AuthServiceImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -312,9 +312,6 @@ public void withdrawMemberById(Long memberId) {
312312
if (currentMember.getProfileImageUrl() != null) {
313313
imageUrlsToDelete.add(currentMember.getProfileImageUrl());
314314
}
315-
if (currentMember.getProfileBackImageUrl() != null) {
316-
imageUrlsToDelete.add(currentMember.getProfileBackImageUrl());
317-
}
318315

319316
// 14. 이미지 삭제 이벤트 발행 (비동기 처리)
320317
if (!imageUrlsToDelete.isEmpty()) {

clokey-api/src/main/java/org/clokey/domain/member/dto/request/ProfileUpdateRequest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,4 @@ public record ProfileUpdateRequest(
1414
String bio,
1515
@NotNull(message = "공개여부는 비워둘 수 없습니다.") @Schema(description = "계정 공개여부", example = "PUBLIC")
1616
Visibility visibility,
17-
@Schema(description = "사용자 프로필 이미지", example = "profile.jpg") String profileImageUrl,
18-
@Schema(description = "사용자 배경 이미지", example = "background.jpg")
19-
String profileBackImageUrl) {}
17+
@Schema(description = "사용자 프로필 이미지", example = "profile.jpg") String profileImageUrl) {}

clokey-api/src/main/java/org/clokey/domain/member/dto/response/ProfileResponse.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ public record ProfileResponse(
1212
@Schema(description = "닉네임", example = "juwon") String nickname,
1313
@Schema(description = "프로필 이미지 URL", example = "https://example.com/profile/john.jpg")
1414
String profileImageUrl,
15-
@Schema(description = "배경 이미지 URL", example = "https://example.com/profile/john.jpg")
16-
String profileBackImageUrl,
1715
@Schema(description = "계정 공개 여부", example = "PUBLIC") Visibility visibility) {
1816
public static ProfileResponse from(Member member) {
1917
return new ProfileResponse(
@@ -22,7 +20,6 @@ public static ProfileResponse from(Member member) {
2220
member.getEmail(),
2321
member.getNickname(),
2422
member.getProfileImageUrl(),
25-
member.getProfileBackImageUrl(),
2623
member.getVisibility());
2724
}
2825
}

clokey-api/src/main/java/org/clokey/domain/member/service/MemberServiceImpl.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,7 @@ public void updateProfile(ProfileUpdateRequest request) {
5454
// s3 삭제 로직 구현 이후에 반영 필요 -> 배경 및 프로필 이미지를 없애버리는 경우
5555

5656
currentMember.updateProfile(
57-
request.nickname(),
58-
request.profileImageUrl(),
59-
request.profileBackImageUrl(),
60-
request.bio(),
61-
request.visibility());
57+
request.nickname(), request.profileImageUrl(), request.bio(), request.visibility());
6258

6359
// Member 동기화
6460
eventPublisher.publishEvent(

clokey-api/src/main/java/org/clokey/domain/notification/dto/response/NotificationListResponse.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ public record NotificationListResponse(
1010
@Schema(description = "알림의 이미지 URL", example = "https://testiamge.com")
1111
String notificationImageUrl,
1212
@Schema(description = "알림의 내용", example = "테스트 알림입니다.") String notificationContent,
13-
@Schema(description = "redirectInfo(clokeyId, historyId 등)", example = "1L")
14-
String redirectInfo,
13+
@Schema(description = "redirectInfo(historyId 등)", example = "1L") String redirectInfo,
1514
@Schema(description = "RedirectType(Member, History 등)", example = "MEMBER_REDIRECT")
1615
RedirectType redirectType,
1716
@Schema(description = "읽음 상태(ReadStatus)", example = "NOT_READ") ReadStatus readStatus,

clokey-api/src/main/java/org/clokey/domain/search/controller/SearchController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,15 +95,15 @@ public BaseResponse<Void> unSyncAllHistories() {
9595

9696
@GetMapping("/members")
9797
@Operation(
98-
operationId = "Search_searchUserByClokeyIdAndNickname",
98+
operationId = "Search_searchUserByNickname",
9999
summary = "유저 검색",
100100
description = "검색탭에서 클로키ID와 닉네임을 통해 유저를 검색할 수 있는 API입니다.")
101-
public BaseResponse<SliceResponse<SearchedMemberResponse>> searchUserByClokeyIdAndNickname(
101+
public BaseResponse<SliceResponse<SearchedMemberResponse>> searchUserByNickname(
102102
@Parameter(description = "검색 키워드 (클로키ID or 닉네임)") @RequestParam String keyword,
103103
@Parameter(description = "페이지 번호") @RequestParam Long page,
104104
@Parameter(description = "페이지당 조회할 유저의 수") @RequestParam @PageSize Integer size) {
105105
SliceResponse<SearchedMemberResponse> response =
106-
searchService.searchUserByClokeyIdAndNickname(keyword, page, size);
106+
searchService.searchUserByNickname(keyword, page, size);
107107
return BaseResponse.onSuccess(GlobalBaseSuccessCode.OK, response);
108108
}
109109

clokey-api/src/main/java/org/clokey/domain/search/service/SearchService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ SliceResponse<SearchedHistoryResponse> searchHistoryByHashtagsAndCategories(
2727

2828
void unSyncAllHistories();
2929

30-
SliceResponse<SearchedMemberResponse> searchUserByClokeyIdAndNickname(
30+
SliceResponse<SearchedMemberResponse> searchUserByNickname(
3131
String keyword, Long page, Integer size);
3232

3333
void syncAllMembers();

clokey-api/src/main/java/org/clokey/domain/search/service/SearchServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ public void unSyncAllHistories() {
163163

164164
@Override
165165
@Transactional(readOnly = true)
166-
public SliceResponse<SearchedMemberResponse> searchUserByClokeyIdAndNickname(
166+
public SliceResponse<SearchedMemberResponse> searchUserByNickname(
167167
String keyword, Long page, Integer size) {
168168
Member currentMember = memberUtil.getCurrentMember();
169169

clokey-api/src/test/java/org/clokey/domain/auth/service/AuthServiceTest.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -346,11 +346,7 @@ void setUp() {
346346
"targetNickName",
347347
OauthInfo.createOauthInfo("targetOauthId", OauthProvider.KAKAO));
348348
targetMember.updateProfile(
349-
"targetNickName",
350-
"profileImageUrl",
351-
"profileBackImageUrl",
352-
"한줄소개",
353-
Visibility.PUBLIC);
349+
"targetNickName", "profileImageUrl", "한줄소개", Visibility.PUBLIC);
354350

355351
Member otherMember =
356352
Member.createMember(
@@ -607,7 +603,6 @@ void setUp() {
607603
assertThat(events.getFirst().imageUrls())
608604
.containsExactlyInAnyOrder(
609605
"profileImageUrl",
610-
"profileBackImageUrl",
611606
"historyImageUrl1",
612607
"historyImageUrl2",
613608
"coordinateImageUrl",

0 commit comments

Comments
 (0)