Skip to content

[DEPLOY] 알림 로직 최적화, 예외처리 추가 및 알림 기본 이미지 URL 사용 추가 배포 #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dev2yup merged 1 commit into from
Apr 30, 2026

[refactor/#412] Notification 검증 로직 효율화 및 잠재적 문제 해결, 예외처리 추가 (#413)

714c779
Select commit
Loading
Failed to load commit list.
Merged

[DEPLOY] 알림 로직 최적화, 예외처리 추가 및 알림 기본 이미지 URL 사용 추가 배포 #414

[refactor/#412] Notification 검증 로직 효율화 및 잠재적 문제 해결, 예외처리 추가 (#413)
714c779
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 30, 2026 in 3m 4s

Quality Gate failed

Failed conditions
73.8% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 163 in clokey-api/src/test/java/org/clokey/domain/notification/service/NotificationServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUPCXmeKWz2oHvYt&open=AZ3fkUPCXmeKWz2oHvYt&pullRequest=414

Check warning on line 358 in clokey-api/src/test/java/org/clokey/domain/notification/service/NotificationServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUPCXmeKWz2oHvYw&open=AZ3fkUPCXmeKWz2oHvYw&pullRequest=414

Check failure on line 164 in clokey-api/src/main/java/org/clokey/domain/notification/service/CodiveNotificationServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "historyId" 3 times. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUIHXmeKWz2oHvW9&open=AZ3fkUIHXmeKWz2oHvW9&pullRequest=414

Check warning on line 227 in clokey-api/src/test/java/org/clokey/domain/feed/service/FeedServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Join these multiple assertions subject to one assertion chain. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUL0XmeKWz2oHvYG&open=AZ3fkUL0XmeKWz2oHvYG&pullRequest=414

Check warning on line 417 in clokey-api/src/test/java/org/clokey/domain/feed/service/FeedServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Join these multiple assertions subject to one assertion chain. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUL0XmeKWz2oHvYI&open=AZ3fkUL0XmeKWz2oHvYI&pullRequest=414

Check warning on line 585 in clokey-api/src/test/java/org/clokey/domain/comment/service/CommentServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThat(actual).hasSize(expected) instead. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkURbXmeKWz2oHvZU&open=AZ3fkURbXmeKWz2oHvZU&pullRequest=414

Check warning on line 1136 in clokey-api/src/test/java/org/clokey/domain/statistics/service/StatisticsServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "member" local variable. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUMxXmeKWz2oHvYN&open=AZ3fkUMxXmeKWz2oHvYN&pullRequest=414

Check warning on line 693 in clokey-api/src/test/java/org/clokey/domain/comment/service/CommentServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThat(actual).isNotPresent() or assertThat(actual).isEmpty() instead. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkURbXmeKWz2oHvZW&open=AZ3fkURbXmeKWz2oHvZW&pullRequest=414

Check warning on line 19 in clokey-api/src/main/java/org/clokey/domain/statistics/controller/StatisticsController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUIzXmeKWz2oHvXB&open=AZ3fkUIzXmeKWz2oHvXB&pullRequest=414

Check warning on line 118 in clokey-api/src/main/java/org/clokey/domain/search/service/SearchServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUFjXmeKWz2oHvWv&open=AZ3fkUFjXmeKWz2oHvWv&pullRequest=414

Check warning on line 218 in clokey-api/src/test/java/org/clokey/domain/feed/service/FeedServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUL0XmeKWz2oHvXr&open=AZ3fkUL0XmeKWz2oHvXr&pullRequest=414

Check warning on line 1529 in clokey-api/src/test/java/org/clokey/domain/coordinate/service/CoordinateServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThat(actual).isEmpty() instead. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUNoXmeKWz2oHvYb&open=AZ3fkUNoXmeKWz2oHvYb&pullRequest=414

Check warning on line 88 in clokey-api/src/test/java/org/clokey/domain/like/service/LikeServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThat(actual).isPresent() instead. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUNOXmeKWz2oHvYU&open=AZ3fkUNOXmeKWz2oHvYU&pullRequest=414

Check warning on line 247 in clokey-api/src/test/java/org/clokey/domain/feed/service/FeedServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUL0XmeKWz2oHvXu&open=AZ3fkUL0XmeKWz2oHvXu&pullRequest=414

Check warning on line 304 in clokey-api/src/test/java/org/clokey/domain/feed/service/FeedServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUL0XmeKWz2oHvX2&open=AZ3fkUL0XmeKWz2oHvX2&pullRequest=414

Check warning on line 220 in clokey-api/src/test/java/org/clokey/domain/feed/service/FeedServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUL0XmeKWz2oHvXt&open=AZ3fkUL0XmeKWz2oHvXt&pullRequest=414

Check warning on line 119 in clokey-api/src/test/java/org/clokey/domain/term/service/TermServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "member". 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUOtXmeKWz2oHvYm&open=AZ3fkUOtXmeKWz2oHvYm&pullRequest=414

Check failure on line 689 in clokey-api/src/test/java/org/clokey/domain/history/service/HistoryServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkULMXmeKWz2oHvXb&open=AZ3fkULMXmeKWz2oHvXb&pullRequest=414

Check warning on line 909 in clokey-api/src/test/java/org/clokey/domain/comment/service/CommentServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThat(actual).isEmpty() instead. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkURbXmeKWz2oHvZb&open=AZ3fkURbXmeKWz2oHvZb&pullRequest=414

Check warning on line 258 in clokey-api/src/test/java/org/clokey/domain/feed/service/FeedServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Join these multiple assertions subject to one assertion chain. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUL0XmeKWz2oHvYH&open=AZ3fkUL0XmeKWz2oHvYH&pullRequest=414

Check warning on line 41 in clokey-api/src/main/java/org/clokey/domain/cloth/repository/ClothRepositoryImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "targetSeasons" local variable. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUJGXmeKWz2oHvXE&open=AZ3fkUJGXmeKWz2oHvXE&pullRequest=414

Check warning on line 135 in clokey-api/src/test/java/org/clokey/domain/notification/service/NotificationServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUPCXmeKWz2oHvYr&open=AZ3fkUPCXmeKWz2oHvYr&pullRequest=414

Check warning on line 46 in clokey-api/src/main/java/org/clokey/domain/history/repository/HistoryRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the missing @deprecated Javadoc tag. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUC4XmeKWz2oHvWq&open=AZ3fkUC4XmeKWz2oHvWq&pullRequest=414

Check warning on line 298 in clokey-api/src/test/java/org/clokey/domain/feed/service/FeedServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUL0XmeKWz2oHvX0&open=AZ3fkUL0XmeKWz2oHvX0&pullRequest=414

Check warning on line 363 in clokey-api/src/test/java/org/clokey/domain/lookbook/service/LookBookServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThat(actual).hasSize(expected) instead. 

See more on https://sonarcloud.io/project/issues?id=Clokey-dev_clokey-server&issues=AZ3fkUP1XmeKWz2oHvY5&open=AZ3fkUP1XmeKWz2oHvY5&pullRequest=414
View more details on SonarQubeCloud