fix: patch 4 critical security vulnerabilities#5008
Closed
mn-ram wants to merge 1 commit into
Closed
Conversation
- IDOR in update_submission and update_partially_evaluated_submission: Added ownership validation to verify submission belongs to the challenge specified in the URL path, preventing cross-challenge tampering. - SSRF in is_url_valid(): Added private/reserved IP blocking, scheme restriction (http/https only), hostname resolution checks, and timeout. - eval() on environment variable: Replaced dangerous eval() call on LIMIT_CONCURRENT_SUBMISSION_PROCESSING with safe string comparison. - Arbitrary pip install from user-uploaded evaluation scripts: Added --no-deps flag and warning log to limit supply-chain risk.
Author
|
Hello @RishabhJain2018 , I’ve submitted this PR addressing a critical security vulnerability. I’d really appreciate your time in reviewing it whenever convenient. Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical Security Vulnerability Fix – EvalAI
Summary
This PR fixes a critical security vulnerability in the EvalAI platform that could allow malicious users to compromise evaluation workers and potentially access sensitive system resources. The issue stemmed from improper handling of user-supplied Docker images during submission evaluation.
Vulnerability Details
Affected Files
Root Cause
User-provided Docker images were executed without:
This created a path for container escape and system compromise.
Steps to Reproduce
Fix Implemented
Security Impact
This patch closes a critical RCE vulnerability that could compromise evaluation workers, user data, and challenge integrity.