Fix: Enforce permissions check on challenge creation (#4859)#5018
Open
Kitan-Dara06 wants to merge 2 commits into
Open
Fix: Enforce permissions check on challenge creation (#4859)#5018Kitan-Dara06 wants to merge 2 commits into
Kitan-Dara06 wants to merge 2 commits into
Conversation
b37d394 to
076913b
Compare
076913b to
e2fba64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4859
Summary
This PR fixes a security vulnerability where users with insufficient permissions (e.g.,
READaccess) or pending invitations could create challenges if they were members of the Host Team.Changes
apps/challenges/views.py: Updatedcreate_challenge_using_zip_fileto replace the weak membership check (if user in members) with a strict database query.ACCEPTED.ADMINorWRITEpermissions. Users withREADaccess are now correctly blocked.Verification
I verified this locally using the Django shell:
ChallengeHostTeam.permissions=ChallengeHost.READ.403 Forbiddenerror (previously, this user would have been allowed to proceed).Checklist