OrderBookIncrementManager: RemoveSubscription returns bool, log only on actual removal

Author: mikasoukhov

Algo/IOrderBookIncrementManagerState.cs

@@ -68,7 +68,8 @@ public interface IOrderBookIncrementManagerState
 	/// <summary>
 	/// Remove subscription.
 	/// </summary>
-	void RemoveSubscription(long id);
+	/// <returns><see langword="true"/> if subscription was found and removed.</returns>
+	bool RemoveSubscription(long id);
 
 	/// <summary>
 	/// Clear all state.

Algo/OrderBookIncrementManager.cs

@@ -162,8 +162,8 @@ public sealed class OrderBookIncrementManager(ILogReceiver logReceiver, IOrderBo
 
 	private void RemoveSubscription(long id)
 	{
-		_state.RemoveSubscription(id);
-		_logReceiver.AddInfoLog("Unsubscribed {0}.", id);
+		if (_state.RemoveSubscription(id))
+			_logReceiver.AddInfoLog("Unsubscribed {0}.", id);
 	}
 
 	/// <inheritdoc/>

Algo/OrderBookIncrementManagerState.cs

@@ -154,7 +154,7 @@ public bool ContainsSubscription(long subscriptionId)
 	}
 
 	/// <inheritdoc />
-	public void RemoveSubscription(long id)
+	public bool RemoveSubscription(long id)
 	{
 		using (_sync.EnterScope())
 		{
@@ -168,17 +168,16 @@ public void RemoveSubscription(long id)
 
 				if (info == null)
 				{
-					_passThrough.Remove(id);
-					_allSecSubscriptions.Remove(id);
-					_allSecSubscriptionsPassThrough.Remove(id);
-					return;
+					return _passThrough.Remove(id) |
+					       _allSecSubscriptions.Remove(id) |
+					       _allSecSubscriptionsPassThrough.Remove(id);
 				}
 			}
 
 			var secId = info.Builder.SecurityId;
 
 			if (info != _online.TryGetValue(secId))
-				return;
+				return false;
 
 			info.SubscriptionIds.Remove(id);
 
@@ -188,6 +187,8 @@ public void RemoveSubscription(long id)
 				_online.Remove(secId);
 			else if (changeId && !_byId.ContainsKey(ids[0]))
 				_byId.Add(ids[0], info);
+
+			return true;
 		}
 	}