Skip to content

chore(ci): add commitlint workflow + config#10

Closed
JCBauza wants to merge 1 commit into
masterfrom
chore/add-commitlint-workflow
Closed

chore(ci): add commitlint workflow + config#10
JCBauza wants to merge 1 commit into
masterfrom
chore/add-commitlint-workflow

Conversation

@JCBauza

@JCBauza JCBauza commented May 9, 2026

Copy link
Copy Markdown
Collaborator

Adds a CI workflow that lints commit messages on every PR using
wagoid/commitlint-github-action with @commitlint/config-conventional
rules. Workflow-only approach (no devDependency or husky hook
changes — zero impact on local dev environment).

Allowed types: feat, fix, docs, style, refactor, perf, test, chore,
build, ci, revert. Header max length 100 chars (warning only).

Plan: .claude-plans/help-me-enable-all-zany-gosling.md (Track C).

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Adds a CI workflow that lints commit messages on every PR using
wagoid/commitlint-github-action with @commitlint/config-conventional
rules. Workflow-only approach (no devDependency or husky hook
changes — zero impact on local dev environment).

Allowed types: feat, fix, docs, style, refactor, perf, test, chore,
build, ci, revert. Header max length 100 chars (warning only).

Plan: .claude-plans/help-me-enable-all-zany-gosling.md (Track C).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 9, 2026 17:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds commit-message linting to CI so PRs are checked against Conventional Commits rules without impacting local developer environments.

Changes:

  • Introduces a GitHub Actions workflow to run commitlint on PR commits.
  • Adds a repo-level .commitlintrc.json extending @commitlint/config-conventional and customizing allowed types / header length.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/commitlint.yml New CI workflow to lint commit messages on pull requests.
.commitlintrc.json Commitlint ruleset (conventional config + repo-specific rule overrides).

Comment on lines +11 to +15
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Lint commits in PR
uses: wagoid/commitlint-github-action@v6

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already addressed in master — the canonical commitlint.yml on master already SHA-pins both actions (actions/checkout@de0fac2e v6.0.2 and wagoid/commitlint-github-action@b948419d v6.2.1, landed via PR #3). This PR was superseded by #3/#6/#7 and is being closed.

Fleet-driver classification: trivial (already-addressed in master, PR superseded). Acknowledged automatically by /jc-coding-fleet-driver v2.x.

@cloudingenium-automation

Copy link
Copy Markdown

Closing — this PR was opened on 2026-04-25 and is now obsolete: master already has the canonical commitlint.yml workflow with SHA-pinned actions (actions/checkout@de0fac2e v6.0.2, wagoid/commitlint-github-action@b948419d v6.2.1) and proper pull-requests: read permission, landed via PRs #3, #6, and #7.

This PR's branch chore/add-commitlint-workflow would actually REGRESS the workflow (downgrade to floating tags @v4 / @v6, remove the pull-requests: read permission). The Copilot SHA-pinning concern (discussion_r3213549116) is already addressed in master.

Per Phase 2.5 fleet-driver doctrine: 'stale PR superseded by main' — close, no forward-fix needed.

Acknowledged automatically by /jc-coding-fleet-driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants