Skip to content

test(json_decoder): guard simplejson encoding-kwarg tolerance (unblocks v6.0.2) #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cloudingenium-automation merged 1 commit into from
Jun 24, 2026
Merged

test(json_decoder): guard simplejson encoding-kwarg tolerance (unblocks v6.0.2) #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/test_json_decoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,12 @@ def test_mixed_content(self):
'{"orderId": 123, "items": [1, 2, 3]}', cls=JSONDecoder
)
assert result == {"order_id": 123, "items": [1, 2, 3]}

def test_tolerates_simplejson_encoding_kwarg(self):
# Regression: `requests` routes response.json(cls=JSONDecoder) through
# simplejson when python3-simplejson is installed, and simplejson.loads
# injects an obsolete `encoding=` kwarg that stdlib json.JSONDecoder
# rejects on Python 3.9+ (TypeError). The decoder must swallow it.
# Without kwargs.pop("encoding", ...) constructing this raises TypeError.
decoder = JSONDecoder(encoding="utf-8")
assert decoder.decode('{"firstName": "John"}') == {"first_name": "John"}
Loading