Version 1.5#52
Merged
Merged
Conversation
Consolidate 6 independent Light/Dark theme pair classes (ColorConfig, ColorPairConfig, ColorsConfig, BackgroundImageConfig, LogoConfig, FaviconConfig) under a shared ThemePairConfig base class for consistency. Add AOT-compatible JSON serialization for .NET 8+ via source-generated MintlifyJsonContext, wire it into MintlifyConstants, mark the assembly as trimmable/AOT-compatible, remove reflection from NavigationPageConverter, and suppress expected IL2026/IL3050 warnings in converters that operate within the serialization pipeline. Add 111 new tests covering ThemePairConfig, inheritance verification, new config model serialization, and AOT round-trip correctness. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Trace warning when falling back to reflection - Maybe the SDK will load the right versions of DotNetDocs in the right SDK environments this time.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MintlifyJsonContextsource-generated serialization and AOT-compatibility pragma suppressions across all convertersThemePairConfigbase class for shared light/dark theme configuration patterns, used byColorPairConfig,BackgroundImageConfig,FaviconConfig,LogoConfig, andError404ConfigAotSerializationTests,ThemePairConfigTests,ThemePairInheritanceTests, andNewConfigTestsNew Mintlify.Core Models
FontConfig— custom font configuration with URL, weight, and styleMetadataConfig— SEO and social metadata settingsThemePairConfig— base class for light/dark theme value pairsThumbnailsConfig— social media thumbnail/OG image settingsThumbnailFontsConfig— font configuration for auto-generated thumbnailsIntegrations
AdobeConfig— Adobe Analytics integrationClarityConfig— Microsoft Clarity integrationCookiesConfig— cookie consent banner configurationFrontChatConfig— Front chat widget integrationIntercomConfig— Intercom messenger integrationKoalaConfig— Koala analytics integrationTelemetryConfig— Telemetry/analytics integrationUpdated Mintlify.Core Models
New properties added to existing models:
ApiConfig—UrlApiExamplesConfig—AutogenerateBackgroundImageConfig— now extendsThemePairConfigColorConfig— additional color propertiesColorPairConfig— now extendsThemePairConfigColorsConfig— additional theme colorsContextualConfig— new propertiesDocsJsonConfig—Fonts,Metadata,Styling,Thumbnails,IntegrationsError404Config— now extendsThemePairConfigFaviconConfig— now extendsThemePairConfigFontsConfig— new propertiesIconConfig/IconsConfig— additional propertiesIntegrationsConfig— all integration sub-configsLogoConfig— now extendsThemePairConfigNavbarLink— new propertiesPostHogConfig— new propertiesStylingConfig— new propertiesTest plan
🤖 Generated with Claude Code